Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update merge on refresh and merge on commit defaults in Opensearch (Lucene 9.3) #3553

Closed
reta opened this issue Jun 9, 2022 · 3 comments · Fixed by #3561
Closed

Update merge on refresh and merge on commit defaults in Opensearch (Lucene 9.3) #3553

reta opened this issue Jun 9, 2022 · 3 comments · Fixed by #3561
Assignees
Labels
enhancement Enhancement or improvement to existing feature or request v2.2.0 v3.0.0 Issues and PRs related to version 3.0.0

Comments

@reta
Copy link
Collaborator

reta commented Jun 9, 2022

Is your feature request related to a problem? Please describe.
The Apache Lucene 9.3 made merge-on-refresh enabled by default [1].

[1] https://github.com/apache/lucene/pull/921/files

Describe the solution you'd like
The Opensearch merge policy has to be updated in order to accommodate this change.

Describe alternatives you've considered
N/A

Additional context
Related to #3537

@reta reta added enhancement Enhancement or improvement to existing feature or request v3.0.0 Issues and PRs related to version 3.0.0 labels Jun 9, 2022
@reta reta self-assigned this Jun 9, 2022
@reta
Copy link
Collaborator Author

reta commented Jun 9, 2022

@nknize fyi

@reta reta changed the title Update merge on refresh and merge on commit on Opensearch (Lucene 9.3) Update merge on refresh and merge on commit defaults in Opensearch (Lucene 9.3) Jun 10, 2022
@reta reta added the v2.1.0 Issues and PRs related to version 2.1.0 label Jun 14, 2022
@elfisher
Copy link

@reta is there anything we should consider documenting regarding this change? Does it have performance implications for users or anything else we should cover in opensearch.org/docs?

@reta
Copy link
Collaborator Author

reta commented Jun 21, 2022

@elfisher yes, I will submit the documentation update for 2.1.0 / 2.2.0. Trying to find out the best place for it and not sure 9.3 will be released before 2.1.0 is out. In general, the change should have only positive performance implications, but we are providing the option to disable it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request v2.2.0 v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants