Fixing test cases caused by enabling merge-on-refresh by default in Lucene 9.3 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrades to latest snapshot of lucene 9.3 Signed-off-by: Nicholas Walter Knize <[email protected]>
…ucene 9.3 Signed-off-by: Andriy Redko <[email protected]>
nknize
force-pushed
the
upgrade/lucene9.3-snapshot-b7231bb
branch
from
1fd19d6
to
1104099
Compare
nknize
reviewed
Jun 9, 2022
| logger.warn( | ||
| "The {} is enabled but {} is set to 0, merge on flush will not be activated", | ||
| IndexSettings.INDEX_MERGE_ON_FLUSH_ENABLED.getKey(), | ||
| IndexSettings.INDEX_MERGE_ON_FLUSH_MAX_FULL_FLUSH_MERGE_WAIT_TIME.getKey() | ||
| ); | ||
| } | ||
| } else { | ||
| iwc.setMaxFullFlushMergeWaitMillis(0); |
There was a problem hiding this comment.
I think we want to retain the 500ms default here per the commit message?
There was a problem hiding this comment.
I updated the testcase to 0ms, though, so we can retain the behavior of not exposing aborted docs.
There was a problem hiding this comment.
No, we explicitly disable merge on refresh since the setting is set to false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andriy Redko [email protected]
Description
Fixing test cases caused by enabling merge-on-refresh by default in Lucene 9.3. A better fix will be done as part of opensearch-project#3553.
Issues Resolved
Part of opensearch-project#3553
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.