Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote Restore Cluster Metadata if local disk state lost after quorum loss recovery #10447

Merged
merged 20 commits into from
Oct 18, 2023

Conversation

linuxpi
Copy link
Collaborator

@linuxpi linuxpi commented Oct 6, 2023

Description

Auto Restore Metadata from remote store if entire local disk state is lost.

As part of 2.10 release we add support to auto restore IndexMetadata f entire local disk state is lost. Now we extend the support to entire Metadata object

Related Issues

Resolves #10525

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Compatibility status:

Checks if related components are compatible with change 6191d6b

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteStoreStatsIT.testStatsResponseAllShards

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #10447 (00697a4) into main (e942483) will decrease coverage by 0.05%.
Report is 5 commits behind head on main.
The diff coverage is 35.55%.

❗ Current head 00697a4 differs from pull request most recent head 6191d6b. Consider uploading reports for the commit 6191d6b to get more accurate results

@@             Coverage Diff              @@
##               main   #10447      +/-   ##
============================================
- Coverage     71.12%   71.08%   -0.05%     
+ Complexity    58503    58432      -71     
============================================
  Files          4853     4853              
  Lines        275915   275696     -219     
  Branches      40153    40117      -36     
============================================
- Hits         196256   195971     -285     
- Misses        63247    63294      +47     
- Partials      16412    16431      +19     
Files Coverage Δ
.../java/org/opensearch/gateway/GatewayMetaState.java 67.28% <100.00%> (-2.50%) ⬇️
...arch/gateway/remote/RemoteClusterStateService.java 67.46% <33.33%> (-0.62%) ⬇️
...arch/index/recovery/RemoteStoreRestoreService.java 10.19% <0.00%> (-1.84%) ⬇️

... and 525 files with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions github-actions bot added the enhancement Enhancement or improvement to existing feature or request label Oct 10, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: bansvaru <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@linuxpi
Copy link
Collaborator Author

linuxpi commented Oct 18, 2023

org.opensearch.client.PitIT.testDeleteAllAndListAllPits

Failing Test is flaky - #5030

@shwetathareja shwetathareja merged commit 56736be into opensearch-project:main Oct 18, 2023
12 of 13 checks passed
@linuxpi linuxpi deleted the global-metadata-restore branch October 18, 2023 17:45
@shwetathareja shwetathareja added the backport 2.x Backport to 2.x branch label Oct 18, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-10447-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 56736be1adaa0c7e97d8db159ff6dca6f6814a9e
# Push it to GitHub
git push --set-upstream origin backport/backport-10447-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-10447-to-2.x.

deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request Oct 19, 2023
… loss recovery (opensearch-project#10447)

* Remote Restore Cluster Metadata if local disk state lost after quorum loss

Signed-off-by: bansvaru <[email protected]>
linuxpi added a commit to linuxpi/OpenSearch that referenced this pull request Oct 19, 2023
… loss recovery (opensearch-project#10447)

* Remote Restore Cluster Metadata if local disk state lost after quorum loss

Signed-off-by: bansvaru <[email protected]>
(cherry picked from commit 56736be)
shwetathareja pushed a commit that referenced this pull request Oct 19, 2023
…st after quorum… (#10742)

* Remote Restore Cluster Metadata if local disk state lost after quorum loss (#10447)

Signed-off-by: bansvaru <[email protected]>
(cherry picked from commit 56736be)
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Oct 23, 2023
… loss recovery (opensearch-project#10447)

* Remote Restore Cluster Metadata if local disk state lost after quorum loss 

Signed-off-by: bansvaru <[email protected]>
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Oct 23, 2023
… loss recovery (opensearch-project#10447)

* Remote Restore Cluster Metadata if local disk state lost after quorum loss

Signed-off-by: bansvaru <[email protected]>
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Dec 13, 2023
… loss recovery (opensearch-project#10447)

* Remote Restore Cluster Metadata if local disk state lost after quorum loss

Signed-off-by: bansvaru <[email protected]>
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Dec 13, 2023
… loss recovery (opensearch-project#10447)

* Remote Restore Cluster Metadata if local disk state lost after quorum loss

Signed-off-by: bansvaru <[email protected]>
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Dec 13, 2023
… loss recovery (opensearch-project#10447)

* Remote Restore Cluster Metadata if local disk state lost after quorum loss

Signed-off-by: bansvaru <[email protected]>
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Dec 13, 2023
… loss recovery (opensearch-project#10447)

* Remote Restore Cluster Metadata if local disk state lost after quorum loss

Signed-off-by: bansvaru <[email protected]>
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Jan 19, 2024
… loss recovery (opensearch-project#10447)

* Remote Restore Cluster Metadata if local disk state lost after quorum loss

Signed-off-by: bansvaru <[email protected]>
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Jan 19, 2024
… loss recovery (opensearch-project#10447)

* Remote Restore Cluster Metadata if local disk state lost after quorum loss

Signed-off-by: bansvaru <[email protected]>
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Jan 19, 2024
… loss recovery (opensearch-project#10447)

* Remote Restore Cluster Metadata if local disk state lost after quorum loss

Signed-off-by: bansvaru <[email protected]>
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Jan 19, 2024
… loss recovery (opensearch-project#10447)

* Remote Restore Cluster Metadata if local disk state lost after quorum loss

Signed-off-by: bansvaru <[email protected]>
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Jan 19, 2024
… loss recovery (opensearch-project#10447)

* Remote Restore Cluster Metadata if local disk state lost after quorum loss

Signed-off-by: bansvaru <[email protected]>
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Feb 6, 2024
… loss recovery (opensearch-project#10447)

* Remote Restore Cluster Metadata if local disk state lost after quorum loss

Signed-off-by: bansvaru <[email protected]>
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Feb 6, 2024
… loss recovery (opensearch-project#10447)

* Remote Restore Cluster Metadata if local disk state lost after quorum loss

Signed-off-by: bansvaru <[email protected]>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
… loss recovery (opensearch-project#10447)

* Remote Restore Cluster Metadata if local disk state lost after quorum loss

Signed-off-by: bansvaru <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed enhancement Enhancement or improvement to existing feature or request Storage:Remote
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Remote State] Restore Global Metadata from Remote state after quorum loss recovery.
4 participants