Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding lucene snapshot to the ci staging repository #11241

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Nov 16, 2023

Description

Adding lucene snapshot to the ci staging repository

Old Location: https://d1nvenhzbhpy0q.cloudfront.net/snapshots/lucene/
New Location: https://ci.opensearch.org/ci/dbc/snapshots/lucene/

Related Issues

Resolves #[Issue number to be closed when this PR is merged]
opensearch-project/opensearch-build#3874

Check List

New functionality includes testing.
All tests pass
New functionality has been documented.
New functionality has javadoc added
Commit changes are listed out in CHANGELOG.md file (See: Changelog)

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Nov 16, 2023

Compatibility status:

Checks if related components are compatible with change b8e2a61

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/sql.git]

@peterzhuamazon
Copy link
Member Author

This change only change github actions, does not break PA in the commit.

Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @peterzhuamazon - this looks good. Do you have an example of this workflow executing?

Copy link
Contributor

❕ Gradle check result for e9acc5f: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testShardRoutingWithNetworkDisruption_FailOpenEnabled
      1 org.opensearch.search.SearchWeightedRoutingIT.testMultiGetWithNetworkDisruption_FailOpenEnabled

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0a9dfec) 71.15% compared to head (b8e2a61) 71.12%.
Report is 39 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11241      +/-   ##
============================================
- Coverage     71.15%   71.12%   -0.03%     
+ Complexity    58787    58719      -68     
============================================
  Files          4883     4883              
  Lines        277145   277145              
  Branches      40284    40284              
============================================
- Hits         197196   197117      -79     
- Misses        63512    63562      +50     
- Partials      16437    16466      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterzhuamazon
Copy link
Member Author

Thanks @peterzhuamazon - this looks good. Do you have an example of this workflow executing?

Here: https://github.com/peterzhuamazon/OpenSearch/actions/runs/6883604580/job/18724492816

@peterzhuamazon
Copy link
Member Author

Hi @peternied @mch2 ,

Add some changes:

  1. Add test results
  2. Add old snapshot push back for now.

Please review if you have time.
Thanks.

Copy link
Contributor

❕ Gradle check result for b8e2a61: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testMultipleSnapshotAndRollback

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@peterzhuamazon peterzhuamazon changed the title Switch lucene snapshot to the ci staging repository Adding lucene snapshot to the ci staging repository Nov 21, 2023
@peternied
Copy link
Member

Thanks for the update @peterzhuamazon could you please:

  • Provide a new example of the workflow executing?
  • For all the build, please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@bbarani
Copy link
Member

bbarani commented Nov 21, 2023

Thanks for the update @peterzhuamazon could you please:

  • Provide a new example of the workflow executing?
  • For all the build, please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

For # 1 , here's the link to GitHub action: https://github.com/peterzhuamazon/OpenSearch/actions/runs/6883604580/job/18724492816

For # 2 , @peterzhuamazon will look in to the retries and create new issues if needed.

@peternied peternied self-assigned this Nov 21, 2023
@peterzhuamazon
Copy link
Member Author

peterzhuamazon commented Nov 27, 2023

@peterzhuamazon
Copy link
Member Author

Hi @peternied @mch2 can we please approve this PR to move forward?
Thanks.

@bbarani
Copy link
Member

bbarani commented Nov 28, 2023

@peternied @mch2 @reta can you please review this PR and provide your feedback / approval?

Copy link
Member

@mch2 mch2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thanks @peterzhuamazon.

Once this is merged I'll trigger a build and test at both endpoints before updating version.properties

@mch2 mch2 merged commit 2898f13 into opensearch-project:main Nov 28, 2023
35 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 28, 2023
* Switch lucene snapshot to the ci staging repository

Signed-off-by: Peter Zhu <[email protected]>

* Add back old s3 lucene uploads for now

Signed-off-by: Peter Zhu <[email protected]>

---------

Signed-off-by: Peter Zhu <[email protected]>
(cherry picked from commit 2898f13)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@peterzhuamazon peterzhuamazon deleted the lucene-snapshot-newrepo branch November 28, 2023 19:42
peterzhuamazon pushed a commit that referenced this pull request Nov 28, 2023
* Switch lucene snapshot to the ci staging repository



* Add back old s3 lucene uploads for now



---------


(cherry picked from commit 2898f13)

Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
fahadshamiinsta pushed a commit to fahadshamiinsta/OpenSearch270 that referenced this pull request Dec 4, 2023
…ct#11241)

* Switch lucene snapshot to the ci staging repository

Signed-off-by: Peter Zhu <[email protected]>

* Add back old s3 lucene uploads for now

Signed-off-by: Peter Zhu <[email protected]>

---------

Signed-off-by: Peter Zhu <[email protected]>
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request Dec 11, 2023
…ct#11241)

* Switch lucene snapshot to the ci staging repository

Signed-off-by: Peter Zhu <[email protected]>

* Add back old s3 lucene uploads for now

Signed-off-by: Peter Zhu <[email protected]>

---------

Signed-off-by: Peter Zhu <[email protected]>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
…ct#11241)

* Switch lucene snapshot to the ci staging repository

Signed-off-by: Peter Zhu <[email protected]>

* Add back old s3 lucene uploads for now

Signed-off-by: Peter Zhu <[email protected]>

---------

Signed-off-by: Peter Zhu <[email protected]>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…ct#11241)

* Switch lucene snapshot to the ci staging repository

Signed-off-by: Peter Zhu <[email protected]>

* Add back old s3 lucene uploads for now

Signed-off-by: Peter Zhu <[email protected]>

---------

Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
Development

Successfully merging this pull request may close these issues.

5 participants