-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding lucene snapshot to the ci staging repository #11241
Adding lucene snapshot to the ci staging repository #11241
Conversation
Signed-off-by: Peter Zhu <[email protected]>
Compatibility status:Checks if related components are compatible with change b8e2a61 Incompatible componentsIncompatible components: [https://github.com/opensearch-project/performance-analyzer.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/sql.git] |
This change only change github actions, does not break PA in the commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @peterzhuamazon - this looks good. Do you have an example of this workflow executing?
❕ Gradle check result for e9acc5f: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11241 +/- ##
============================================
- Coverage 71.15% 71.12% -0.03%
+ Complexity 58787 58719 -68
============================================
Files 4883 4883
Lines 277145 277145
Branches 40284 40284
============================================
- Hits 197196 197117 -79
- Misses 63512 63562 +50
- Partials 16437 16466 +29 ☔ View full report in Codecov by Sentry. |
Here: https://github.com/peterzhuamazon/OpenSearch/actions/runs/6883604580/job/18724492816 |
Signed-off-by: Peter Zhu <[email protected]>
Hi @peternied @mch2 , Add some changes:
Please review if you have time. |
❕ Gradle check result for b8e2a61: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Thanks for the update @peterzhuamazon could you please:
|
For # 1 , here's the link to GitHub action: https://github.com/peterzhuamazon/OpenSearch/actions/runs/6883604580/job/18724492816 For # 2 , @peterzhuamazon will look in to the retries and create new issues if needed. |
Hi @peternied @mch2 can we please approve this PR to move forward? |
@peternied @mch2 @reta can you please review this PR and provide your feedback / approval? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, thanks @peterzhuamazon.
Once this is merged I'll trigger a build and test at both endpoints before updating version.properties
* Switch lucene snapshot to the ci staging repository Signed-off-by: Peter Zhu <[email protected]> * Add back old s3 lucene uploads for now Signed-off-by: Peter Zhu <[email protected]> --------- Signed-off-by: Peter Zhu <[email protected]> (cherry picked from commit 2898f13) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Switch lucene snapshot to the ci staging repository * Add back old s3 lucene uploads for now --------- (cherry picked from commit 2898f13) Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ct#11241) * Switch lucene snapshot to the ci staging repository Signed-off-by: Peter Zhu <[email protected]> * Add back old s3 lucene uploads for now Signed-off-by: Peter Zhu <[email protected]> --------- Signed-off-by: Peter Zhu <[email protected]>
…ct#11241) * Switch lucene snapshot to the ci staging repository Signed-off-by: Peter Zhu <[email protected]> * Add back old s3 lucene uploads for now Signed-off-by: Peter Zhu <[email protected]> --------- Signed-off-by: Peter Zhu <[email protected]>
…ct#11241) * Switch lucene snapshot to the ci staging repository Signed-off-by: Peter Zhu <[email protected]> * Add back old s3 lucene uploads for now Signed-off-by: Peter Zhu <[email protected]> --------- Signed-off-by: Peter Zhu <[email protected]>
…ct#11241) * Switch lucene snapshot to the ci staging repository Signed-off-by: Peter Zhu <[email protected]> * Add back old s3 lucene uploads for now Signed-off-by: Peter Zhu <[email protected]> --------- Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
Adding lucene snapshot to the ci staging repository
Old Location: https://d1nvenhzbhpy0q.cloudfront.net/snapshots/lucene/
New Location: https://ci.opensearch.org/ci/dbc/snapshots/lucene/
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
opensearch-project/opensearch-build#3874
Check List
New functionality includes testing.All tests passNew functionality has been documented.New functionality has javadoc addedCommit changes are listed out in CHANGELOG.md file (See: Changelog)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.