Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple remote state configuration #11858

Merged
merged 4 commits into from
Mar 18, 2024

Conversation

soosinha
Copy link
Member

@soosinha soosinha commented Jan 11, 2024

Description

For remote store, segment and translog repo need to be configured. For remote state, cluster state repo is required. But as per current logic either all three repos should be present or none of them should be preesnt. So remote state is tightly coupled with remote store.
This PR decouples the remote state setting so that it can be enabled or disabled as an independent feature.

Related Issues

#9884

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Jan 11, 2024

Compatibility status:

Checks if related components are compatible with change db7683c

Incompatible components

Incompatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/alerting.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/sql.git]

Copy link
Contributor

❌ Gradle check result for d8ab19e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 3f67648: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@soosinha
Copy link
Member Author

Tagging @shwetathareja @psychbot for review.

@shwetathareja
Copy link
Member

No other major comment, lets add new test cover new combination where remote state is enabled without remote store for segments.

Copy link
Contributor

❌ Gradle check result for 8e220e2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@soosinha
Copy link
Member Author

Gradle check failure due to flaky test: #12593

Copy link
Contributor

❕ Gradle check result for db7683c: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@soosinha
Copy link
Member Author

Gradle check failure due to flaky test: #10558

@gbbafna
Copy link
Collaborator

gbbafna commented Mar 15, 2024

@soosinha : Would existing non-remote clusters be able to use remote state after upgrading to whatever the version we are targeting ?

@sachinpkale sachinpkale merged commit 00d4b71 into opensearch-project:main Mar 18, 2024
33 of 39 checks passed
@sachinpkale sachinpkale added the backport 2.x Backport to 2.x branch label Mar 18, 2024
@soosinha
Copy link
Member Author

@gbbafna Yes Existing non-remote store clusters should be able to use remote state after upgrade.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 18, 2024
* Decouple remote state configuration

Signed-off-by: Sooraj Sinha <[email protected]>
(cherry picked from commit 00d4b71)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
* Decouple remote state configuration

Signed-off-by: Sooraj Sinha <[email protected]>
reta added a commit to reta/OpenSearch that referenced this pull request Mar 18, 2024
sachinpkale pushed a commit that referenced this pull request Mar 19, 2024
* Decouple remote state configuration


(cherry picked from commit 00d4b71)

Signed-off-by: Sooraj Sinha <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruai0511 pushed a commit to ruai0511/OpenSearch that referenced this pull request Mar 19, 2024
* Decouple remote state configuration

Signed-off-by: Sooraj Sinha <[email protected]>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
* Decouple remote state configuration

Signed-off-by: Sooraj Sinha <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

6 participants