Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for https://bugs.openjdk.org/browse/JDK-8323659 regression, introduced in JDK-21.0.2 #11968

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

reta
Copy link
Collaborator

@reta reta commented Jan 22, 2024

Description

Workaround for https://bugs.openjdk.org/browse/JDK-8323659 regression, introduced in JDK-21.0.2

Related Issues

See please #11906

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Jan 22, 2024

Compatibility status:

Checks if related components are compatible with change 286cc9c

Incompatible components

Incompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/k-nn.git]

Copy link
Contributor

❕ Gradle check result for e6c3093: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteStoreStatsIT.testNonZeroPrimaryStatsOnNewlyCreatedIndexWithZeroDocs

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (761e13b) 70.86% compared to head (2f786e4) 71.41%.
Report is 2 commits behind head on main.

❗ Current head 2f786e4 differs from pull request most recent head 286cc9c. Consider uploading reports for the commit 286cc9c to get more accurate results

Files Patch % Lines
...ch/common/util/concurrent/OpenSearchExecutors.java 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11968      +/-   ##
============================================
+ Coverage     70.86%   71.41%   +0.54%     
- Complexity    58982    59398     +416     
============================================
  Files          4923     4923              
  Lines        279214   279218       +4     
  Branches      40596    40596              
============================================
+ Hits         197877   199398    +1521     
+ Misses        64876    63230    -1646     
- Partials      16461    16590     +129     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta
Copy link
Collaborator Author

reta commented Jan 22, 2024

Looks like a related failure

Yeah, this is a new test, the latch is released inside pool worker but check may be performed while the task is not yet returned, changed the assertion check to be more robust.

Copy link
Contributor

✅ Gradle check result for 2f786e4: SUCCESS

@deshsidd
Copy link
Contributor

Code coverage check still not passing. Might need to add more tests?

@reta
Copy link
Collaborator Author

reta commented Jan 22, 2024

Code coverage check still not passing. Might need to add more tests?

We've been exercising only LinkedTransferQueue#put because this is what our internal policy uses.

Copy link
Contributor

❌ Gradle check result for 768a430: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

…, introduced in JDK-21.0.2

Signed-off-by: Andriy Redko <[email protected]>
@reta
Copy link
Collaborator Author

reta commented Jan 22, 2024

❌ Gradle check result for 768a430: FAILURE

#11974

Copy link
Contributor

❕ Gradle check result for 286cc9c: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing
      1 org.opensearch.action.admin.cluster.tasks.PendingTasksBlocksIT.testPendingTasksWithClusterNotRecoveredBlock

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@reta reta merged commit 48fdb4f into opensearch-project:main Jan 23, 2024
30 checks passed
@reta reta added backport 2.x Backport to 2.x branch and removed skip-changelog labels Jan 23, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 23, 2024
…, introduced in JDK-21.0.2 (#11968)

Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit 48fdb4f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kotwanikunal pushed a commit that referenced this pull request Jan 23, 2024
…, introduced in JDK-21.0.2 (#11968) (#11988)

(cherry picked from commit 48fdb4f)

Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Mar 1, 2024
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…, introduced in JDK-21.0.2 (opensearch-project#11968)

Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants