Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x][Tiered Caching] Enable serialization of IndicesRequestCache.Key (#10… #11972

Merged
merged 4 commits into from
Feb 7, 2024

Conversation

sgup432
Copy link
Contributor

@sgup432 sgup432 commented Jan 22, 2024

Description

Backport #10275

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…nsearch-project#10275)

---------

Signed-off-by: Sagar Upadhyaya <[email protected]>
Signed-off-by: Sagar <[email protected]>
Co-authored-by: Kiran Prakash <[email protected]>
@sgup432
Copy link
Contributor Author

sgup432 commented Jan 22, 2024

@msfroh Need help with merging this backport PR.

Copy link
Contributor

github-actions bot commented Jan 22, 2024

Compatibility status:

Checks if related components are compatible with change fefa97d

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/sql.git]

Copy link
Contributor

❌ Gradle check result for 74608b1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sgup432 sgup432 changed the title [Tiered Caching] Enable serialization of IndicesRequestCache.Key (#10… [Backport 2.x][Tiered Caching] Enable serialization of IndicesRequestCache.Key (#10… Jan 30, 2024
Copy link
Contributor

❌ Gradle check result for bec8c3d:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for bec8c3d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sgup432
Copy link
Contributor Author

sgup432 commented Jan 31, 2024

Seems like a flaky test is failing

org.opensearch.search.sort.FieldSortIT.testSimpleSorts {p0={"search.concurrent_segment_search.enabled":"true"}}

Copy link
Contributor

github-actions bot commented Feb 5, 2024

❌ Gradle check result for e0d5e7b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Feb 5, 2024

❕ Gradle check result for bec8c3d: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteStoreStatsIT.testDownloadStatsCorrectnessSinglePrimarySingleReplica

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (49c0c50) 71.15% compared to head (bec8c3d) 71.16%.
Report is 1 commits behind head on 2.x.

❗ Current head bec8c3d differs from pull request most recent head fefa97d. Consider uploading reports for the commit fefa97d to get more accurate results

Files Patch % Lines
...va/org/opensearch/indices/IndicesRequestCache.java 90.90% 0 Missing and 4 partials ⚠️
...common/lucene/index/OpenSearchDirectoryReader.java 94.11% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##                2.x   #11972     +/-   ##
===========================================
  Coverage     71.15%   71.16%             
+ Complexity    59675    59412    -263     
===========================================
  Files          4921     4891     -30     
  Lines        281132   280029   -1103     
  Branches      41184    41076    -108     
===========================================
- Hits         200050   199277    -773     
+ Misses        64143    63857    -286     
+ Partials      16939    16895     -44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 6, 2024

❌ Gradle check result for fefa97d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Feb 7, 2024

❕ Gradle check result for fefa97d: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@msfroh msfroh merged commit 03d48e9 into opensearch-project:2.x Feb 7, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants