Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Segment Replication] Add Segment Replication Specific Integration Tests #12270

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 30c4210 from #11773.

…sts (#11773)

* Run few tests with Segment Replication enabled.

Signed-off-by: Rishikesh1159 <[email protected]>

* Update reason for ignoring test.

Signed-off-by: Rishikesh1159 <[email protected]>

* remove @ignore to resolve :server:forbiddenApisInternalClusterTest check.

Signed-off-by: Rishikesh1159 <[email protected]>

* fix spotlessCheck.

Signed-off-by: Rishikesh1159 <[email protected]>

* add conditional logic of force refresh.

Signed-off-by: Rishikesh1159 <[email protected]>

* Address comments on PR.

Signed-off-by: Rishikesh1159 <[email protected]>

* fix failing errors.

Signed-off-by: Rishikesh1159 <[email protected]>

* Use parameterization for running segment replication tests.

Signed-off-by: Rishikesh1159 <[email protected]>

* Fix failing tests.

Signed-off-by: Rishikesh1159 <[email protected]>

* Fix failing test.

Signed-off-by: Rishikesh1159 <[email protected]>

* add new waitForReplication() and refactor.

Signed-off-by: Rishikesh1159 <[email protected]>

* Address comments on PR and revert back changes made to SegmentReplication Tests.

Signed-off-by: Rishikesh1159 <[email protected]>

* revert changes made to Segrep tests.

Signed-off-by: Rishikesh1159 <[email protected]>

* Refactor and address comments.

Signed-off-by: Rishikesh1159 <[email protected]>

* fix failure of using forbidden api new Random().

Signed-off-by: Rishikesh1159 <[email protected]>

* Add comments to debug.

Signed-off-by: Rishikesh1159 <[email protected]>

* Remove non-critical tests from running with segrep.

Signed-off-by: Rishikesh1159 <[email protected]>

* Fix test to run with segrep.

Signed-off-by: Rishikesh1159 <[email protected]>

* separate out refresh and waitForReplication into different methods.

Signed-off-by: Rishikesh1159 <[email protected]>

* refactor with usage of waitForReplication().

Signed-off-by: Rishikesh1159 <[email protected]>

* fix parameters passed in factory for IndexStatsIT.

Signed-off-by: Rishikesh1159 <[email protected]>

* Update IndexstatsIT to run with segrep

Signed-off-by: Rishikesh1159 <[email protected]>

---------

Signed-off-by: Rishikesh1159 <[email protected]>
(cherry picked from commit 30c4210)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Feb 9, 2024

Compatibility status:

Checks if related components are compatible with change cb86753

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

github-actions bot commented Feb 9, 2024

❕ Gradle check result for cb86753: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteStoreStatsIT.testNonZeroPrimaryStatsOnNewlyCreatedIndexWithZeroDocs
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a98f719) 71.19% compared to head (cb86753) 71.20%.
Report is 3 commits behind head on 2.x.

Additional details and impacted files
@@            Coverage Diff            @@
##                2.x   #12270   +/-   ##
=========================================
  Coverage     71.19%   71.20%           
+ Complexity    59951    59911   -40     
=========================================
  Files          4940     4940           
  Lines        282025   282025           
  Branches      41306    41306           
=========================================
+ Hits         200790   200809   +19     
+ Misses        64249    64201   -48     
- Partials      16986    17015   +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kotwanikunal kotwanikunal merged commit 110be26 into 2.x Feb 15, 2024
56 of 82 checks passed
@github-actions github-actions bot deleted the backport/backport-11773-to-2.x branch February 15, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants