Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump antlr4 from 4.11.1 to 4.13.1 #12445

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

reta
Copy link
Collaborator

@reta reta commented Feb 23, 2024

Description

Bump antlr4 from 4.11.1 to 4.13.1

Related Issues

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Feb 23, 2024

Compatibility status:

Checks if related components are compatible with change a6dd4eb

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

❌ Gradle check result for 02541f0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 04870e6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator Author

reta commented Feb 26, 2024

❌ Gradle check result for 04870e6: FAILURE

#12308

Copy link
Contributor

❕ Gradle check result for 04870e6: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testRequestStats
      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.classMethod

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 10.52632% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 71.18%. Comparing base (f90baa2) to head (a6dd4eb).
Report is 1 commits behind head on main.

Files Patch % Lines
.../org/opensearch/painless/antlr/PainlessParser.java 5.55% 1 Missing and 16 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12445      +/-   ##
============================================
- Coverage     71.45%   71.18%   -0.27%     
+ Complexity    59895    59741     -154     
============================================
  Files          4972     4972              
  Lines        281781   281781              
  Branches      40910    40910              
============================================
- Hits         201337   200584     -753     
- Misses        63757    64520     +763     
+ Partials      16687    16677      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

❕ Gradle check result for a6dd4eb: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.index.IndexServiceTests.testAsyncTranslogTrimTaskOnClosedIndex

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@reta
Copy link
Collaborator Author

reta commented Feb 26, 2024

@kotwanikunal may I ask you please to re-approve (after resolving conflicts), thank you

@reta reta merged commit 24d7098 into opensearch-project:main Feb 26, 2024
29 of 30 checks passed
@reta reta added dependencies Pull requests that update a dependency file backport 2.x Backport to 2.x branch labels Feb 26, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-12445-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 24d7098fbadfe5a220b44fc029352a955b72d96e
# Push it to GitHub
git push --set-upstream origin backport/backport-12445-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-12445-to-2.x.

reta added a commit to reta/OpenSearch that referenced this pull request Feb 26, 2024
Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit 24d7098)
reta added a commit to reta/OpenSearch that referenced this pull request Feb 26, 2024
Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit 24d7098)
reta added a commit that referenced this pull request Feb 26, 2024
Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit 24d7098)
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Mar 1, 2024
amkhar pushed a commit to amkhar/OpenSearch that referenced this pull request Mar 12, 2024
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants