-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Remote Store] Add support for randomizing Remote Store enabled testing. #12488
[Remote Store] Add support for randomizing Remote Store enabled testing. #12488
Conversation
Signed-off-by: Rishikesh1159 <[email protected]>
Compatibility status:Checks if related components are compatible with change 47bc4b8 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git] |
❌ Gradle check result for fff31d2: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…re_for_IntegTests
❌ Gradle check result for 56a7221: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…re_for_IntegTests
Signed-off-by: Rishikesh1159 <[email protected]>
❌ Gradle check result for a75d13c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for b3f3abd: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…of once per node. Signed-off-by: Rishikesh1159 <[email protected]>
test/framework/src/main/java/org/opensearch/test/OpenSearchIntegTestCase.java
Outdated
Show resolved
Hide resolved
❕ Gradle check result for b3346bd: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12488 +/- ##
============================================
+ Coverage 71.42% 71.47% +0.05%
- Complexity 59978 60405 +427
============================================
Files 4985 5026 +41
Lines 282275 284463 +2188
Branches 40946 41200 +254
============================================
+ Hits 201603 203334 +1731
- Misses 63999 64284 +285
- Partials 16673 16845 +172 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Rishikesh1159 <[email protected]>
❌ Gradle check result for dd0c698: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…re_for_IntegTests
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-12488-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c0b18999fb755cc2cf60b39619fb5bb107307e13
# Push it to GitHub
git push --set-upstream origin backport/backport-12488-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…ng. (opensearch-project#12488) * Add support for randomizing remote store enabled testing. Signed-off-by: Rishikesh1159 <[email protected]> * fix spotless check Signed-off-by: Rishikesh1159 <[email protected]> * Updating logic to randomly use remote store once per cluster instead of once per node. Signed-off-by: Rishikesh1159 <[email protected]> * Add Remote Store Randomization within Replication Type Randomization. Signed-off-by: Rishikesh1159 <[email protected]> --------- Signed-off-by: Rishikesh1159 <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Signed-off-by: Rishikesh1159 <[email protected]>
Looks like #13845 never made it. |
…ng (#13845) * backport #12488 to 2.x branch. Signed-off-by: Rishikesh1159 <[email protected]> * Fix indentation. Signed-off-by: Rishikesh1159 <[email protected]> --------- Signed-off-by: Rishikesh1159 <[email protected]> Signed-off-by: Rishikesh <[email protected]>
…ng (opensearch-project#13845) * backport opensearch-project#12488 to 2.x branch. Signed-off-by: Rishikesh1159 <[email protected]> * Fix indentation. Signed-off-by: Rishikesh1159 <[email protected]> --------- Signed-off-by: Rishikesh1159 <[email protected]> Signed-off-by: Rishikesh <[email protected]>
Description
This PR enables the support for randomizing Remote Store enabled testing. This helps to increase the Remote Store test coverage by randomly using remote backed storage for tests not critical of remote store.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.