-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing unused fetch sub phase processor initialization during fetch… #12503
Conversation
… phase execution Signed-off-by: Ankit Jain <[email protected]>
Compatibility status:Checks if related components are compatible with change 2bd910e Incompatible componentsIncompatible components: [https://github.com/opensearch-project/security-analytics.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git] |
❌ Gradle check result for a742967: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-12503-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 da5b2053864f24dcb3b8c555a9fd19e0d91a14e6
# Push it to GitHub
git push --set-upstream origin backport/backport-12503-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
@jainankitk could you please backport manually to |
opensearch-project#12503) * Removing unused fetch sub phase processor initialization during fetch phase execution Signed-off-by: Ankit Jain <[email protected]> * Updating CHANGELOG.md with the bug fix Signed-off-by: Ankit Jain <[email protected]> * Fixing smoke test failures Signed-off-by: Ankit Jain <[email protected]> * Addressing review comments Signed-off-by: Ankit Jain <[email protected]> * Addressing review comments around boolean check convention Signed-off-by: Ankit Jain <[email protected]> --------- Signed-off-by: Ankit Jain <[email protected]> (cherry picked from commit da5b205)
…on during fetch… (#12654) * Removing unused fetch sub phase processor initialization during fetch… (#12503) * Removing unused fetch sub phase processor initialization during fetch phase execution Signed-off-by: Ankit Jain <[email protected]> * Updating CHANGELOG.md with the bug fix Signed-off-by: Ankit Jain <[email protected]> * Fixing smoke test failures Signed-off-by: Ankit Jain <[email protected]> * Addressing review comments Signed-off-by: Ankit Jain <[email protected]> * Addressing review comments around boolean check convention Signed-off-by: Ankit Jain <[email protected]> --------- Signed-off-by: Ankit Jain <[email protected]> (cherry picked from commit da5b205) * Removing unintended CHANGELOG issue Signed-off-by: Ankit Jain <[email protected]> --------- Signed-off-by: Ankit Jain <[email protected]>
opensearch-project#12503) * Removing unused fetch sub phase processor initialization during fetch phase execution Signed-off-by: Ankit Jain <[email protected]> * Updating CHANGELOG.md with the bug fix Signed-off-by: Ankit Jain <[email protected]> * Fixing smoke test failures Signed-off-by: Ankit Jain <[email protected]> * Addressing review comments Signed-off-by: Ankit Jain <[email protected]> * Addressing review comments around boolean check convention Signed-off-by: Ankit Jain <[email protected]> --------- Signed-off-by: Ankit Jain <[email protected]>
opensearch-project#12503) * Removing unused fetch sub phase processor initialization during fetch phase execution Signed-off-by: Ankit Jain <[email protected]> * Updating CHANGELOG.md with the bug fix Signed-off-by: Ankit Jain <[email protected]> * Fixing smoke test failures Signed-off-by: Ankit Jain <[email protected]> * Addressing review comments Signed-off-by: Ankit Jain <[email protected]> * Addressing review comments around boolean check convention Signed-off-by: Ankit Jain <[email protected]> --------- Signed-off-by: Ankit Jain <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
…ng fetch… (opensearch-project#12503)" This reverts commit da5b205.
…ng fetch… (opensearch-project#12503)" This reverts commit da5b205. Signed-off-by: Andriy Redko <[email protected]>
…ng fetch… (#12503)" (#13486) This reverts commit da5b205. Signed-off-by: Andriy Redko <[email protected]>
…ng fetch… (#12503)" (#13486) This reverts commit da5b205. Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit 5133e5f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ng fetch… (#12503)" (#13486) This reverts commit da5b205. Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit 5133e5f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ng fetch… (#12503)" (#13486) This reverts commit da5b205. Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit 5133e5f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <[email protected]>
…ng fetch… (#12503)" (#13486) This reverts commit da5b205. Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit 5133e5f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <[email protected]>
…tialization during fetch… (#12503)" (#13492) * Revert "Removing unused fetch sub phase processor initialization during fetch… (#12503)" (#13486) This reverts commit da5b205. Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit 5133e5f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <[email protected]> * Update 400_inner_hits.yml Signed-off-by: Andriy Redko <[email protected]> --------- Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Andriy Redko <[email protected]>
…ialization during fetch… (#12503)" (#13491) * Revert "Removing unused fetch sub phase processor initialization during fetch… (#12503)" (#13486) This reverts commit da5b205. Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit 5133e5f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <[email protected]> * Update 400_inner_hits.yml Signed-off-by: Andriy Redko <[email protected]> --------- Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Andriy Redko <[email protected]>
…ng fetch… (opensearch-project#12503)" (opensearch-project#13486) This reverts commit da5b205. Signed-off-by: Andriy Redko <[email protected]>
…ng fetch… (opensearch-project#12503)" (opensearch-project#13486) This reverts commit da5b205. Signed-off-by: Andriy Redko <[email protected]>
…ng fetch… (opensearch-project#12503)" (opensearch-project#13486) This reverts commit da5b205. Signed-off-by: Andriy Redko <[email protected]>
… phase execution
Description
Prevent initialization of unused fetch sub phase processor initialization during fetch phase execution
Related Issues
Resolves #12502
Check List
[ ] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)[ ] Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.