Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with feature flags where default value may not be honored #12849

Merged
merged 7 commits into from
Mar 25, 2024
Merged

Fix issue with feature flags where default value may not be honored #12849

merged 7 commits into from
Mar 25, 2024

Commits on Mar 22, 2024

  1. Fix issue with feature flags passed as system props where default val… 

    …ue was not being honored

Signed-off-by: Craig Perkins <[email protected]>
    @cwperks
    cwperks committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    daaabc4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix-feature-flags

    @cwperks
    cwperks committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    bbead85 View commit details
    Browse the repository at this point in the history

  3. Add CHANGELOG entry 

    Signed-off-by: Craig Perkins <[email protected]>
    @cwperks
    cwperks committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    86769ec View commit details
    Browse the repository at this point in the history

  4. Add test for default value of false 

    Signed-off-by: Craig Perkins <[email protected]>
    @cwperks
    cwperks committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    ea21ee8 View commit details
    Browse the repository at this point in the history

  5. Fix issue when empty settings passed in initialization 

    Signed-off-by: Craig Perkins <[email protected]>
    @cwperks
    cwperks committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    c8885f9 View commit details
    Browse the repository at this point in the history

  6. Get actual value from settings and default from ff setting 

    Signed-off-by: Craig Perkins <[email protected]>
    @cwperks
    cwperks committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    768e161 View commit details
    Browse the repository at this point in the history

  7. Add test with non-empty setting initialization 

    Signed-off-by: Craig Perkins <[email protected]>
    @cwperks
    cwperks committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    565109e View commit details
    Browse the repository at this point in the history