Revert "Add explicit dependency to validatePom and generatePom tasks (#12807)" #12863

reta · 2024-03-22T14:51:49Z

This reverts commit c04dad5.

Description

Revert "Add explicit dependency to validatePom and generatePom tasks (#12807)

Related Issues

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)
Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…opensearch-project#12807)" This reverts commit c04dad5. Signed-off-by: Andriy Redko <[email protected]>

reta · 2024-03-22T14:53:12Z

@cwperks fyi, thanks again

github-actions · 2024-03-22T15:14:03Z

Compatibility status:

Checks if related components are compatible with change c30d5d9

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git]

github-actions · 2024-03-22T15:20:49Z

❌ Gradle check result for c30d5d9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

reta · 2024-03-22T15:29:05Z

❌ Gradle check result for c30d5d9: FAILURE

#12595
#12306
#12239

cwperks · 2024-03-22T15:44:38Z

TY for the help here @reta! I will review the initial PR to see if I can provide any insight on how to prevent it from being a breaking change to the plugins.

github-actions · 2024-03-22T16:58:47Z

❌ Gradle check result for c30d5d9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

reta · 2024-03-22T17:09:02Z

❌ Gradle check result for c30d5d9: FAILURE

Caused by: java.lang.OutOfMemoryError: Java heap space

zelinh · 2024-03-22T17:11:17Z

Would changing back ConfigureEach to all possibly resolve the incompatible issue with security plugin?

reta · 2024-03-22T17:16:53Z

Would changing back ConfigureEach to all possibly resolve the incompatible issue with security plugin?

We need to test that and other plugins

github-actions · 2024-03-22T17:40:29Z

❌ Gradle check result for c30d5d9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

andrross · 2024-03-22T17:48:05Z

❌ Gradle check result for c30d5d9: FAILURE

> Task :qa:wildfly:composeUp FAILED
Get "https://quay.io/v2/": context deadline exceeded (Client.Timeout exceeded while awaiting headers)

github-actions · 2024-03-22T18:31:13Z

❌ Gradle check result for c30d5d9:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-03-22T19:47:44Z

❌ Gradle check result for c30d5d9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

reta · 2024-03-22T20:10:15Z

❌ Gradle check result for c30d5d9: FAILURE

#10006

java.lang.Exception: Test abandoned because suite timeout was reached.
	at __randomizedtesting.SeedInfo.seed([81B30C60E4925A1F]:0)

github-actions · 2024-03-22T21:04:45Z

❕ Gradle check result for c30d5d9: UNSTABLE

TEST FAILURES:

      1 org.opensearch.index.IndexServiceTests.testAsyncTranslogTrimTaskOnClosedIndex

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

codecov · 2024-03-22T21:05:50Z

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 71.38%. Comparing base (b15cb0c) to head (c30d5d9).
Report is 81 commits behind head on main.

Files	Patch %	Lines
...gradle/precommit/PomValidationPrecommitPlugin.java	20.00%	4 Missing ⚠️
.../java/org/opensearch/gradle/pluginzip/Publish.java	0.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #12863      +/-   ##
============================================
- Coverage     71.42%   71.38%   -0.05%     
- Complexity    59978    60265     +287     
============================================
  Files          4985     5011      +26     
  Lines        282275   283667    +1392     
  Branches      40946    41117     +171     
============================================
+ Hits         201603   202483     +880     
- Misses        63999    64411     +412     
- Partials      16673    16773     +100

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zelinh · 2024-03-22T21:06:43Z

Would changing back ConfigureEach to all possibly resolve the incompatible issue with security plugin?

We need to test that and other plugins

I just tested that changing back to all can run assemble on security plugin successfully.

☁  ~/workplace/security[main] ./gradlew assemble
=======================================
OpenSearch Build Hamster says Hello!
  Gradle Version        : 8.5
  OS Info               : Mac OS X 14.3 (x86_64)
  JDK Version           : 21 (Oracle JDK)
  JAVA_HOME             : /Library/Java/JavaVirtualMachines/jdk-21.jdk/Contents/Home
  Random Testing Seed   : C82B0FF391C689CE
  In FIPS 140 mode      : false
=======================================

> Task :compileJava
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.5/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD SUCCESSFUL in 44s
11 actionable tasks: 11 executed

This might be the issue that the previous compatibility tests failed on security plugin. #12807 (comment)

zelinh · 2024-03-22T21:48:45Z

@reta I raised a PR to fix the incompatibility for security plugin. You can take a look there. #12876

reta · 2024-03-22T21:52:15Z

Closing in favor of #12876, thanks @zelinh

Revert "Add explicit dependency to validatePom and generatePom tasks. (…

c30d5d9

…opensearch-project#12807)" This reverts commit c04dad5. Signed-off-by: Andriy Redko <[email protected]>

reta closed this Mar 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert "Add explicit dependency to validatePom and generatePom tasks (#12807)" #12863

Revert "Add explicit dependency to validatePom and generatePom tasks (#12807)" #12863

reta commented Mar 22, 2024 •

edited

Loading

reta commented Mar 22, 2024

github-actions bot commented Mar 22, 2024

github-actions bot commented Mar 22, 2024

reta commented Mar 22, 2024

cwperks commented Mar 22, 2024

github-actions bot commented Mar 22, 2024

reta commented Mar 22, 2024

zelinh commented Mar 22, 2024

reta commented Mar 22, 2024

github-actions bot commented Mar 22, 2024

andrross commented Mar 22, 2024

github-actions bot commented Mar 22, 2024

github-actions bot commented Mar 22, 2024

reta commented Mar 22, 2024

github-actions bot commented Mar 22, 2024

codecov bot commented Mar 22, 2024

zelinh commented Mar 22, 2024

zelinh commented Mar 22, 2024

reta commented Mar 22, 2024 •

edited

Loading

Revert "Add explicit dependency to validatePom and generatePom tasks (#12807)" #12863

Revert "Add explicit dependency to validatePom and generatePom tasks (#12807)" #12863

Conversation

reta commented Mar 22, 2024 • edited Loading

Description

Related Issues

Check List

reta commented Mar 22, 2024

github-actions bot commented Mar 22, 2024

Compatibility status:

Incompatible components

Skipped components

Compatible components

github-actions bot commented Mar 22, 2024

reta commented Mar 22, 2024

cwperks commented Mar 22, 2024

github-actions bot commented Mar 22, 2024

reta commented Mar 22, 2024

zelinh commented Mar 22, 2024

reta commented Mar 22, 2024

github-actions bot commented Mar 22, 2024

andrross commented Mar 22, 2024

github-actions bot commented Mar 22, 2024

github-actions bot commented Mar 22, 2024

reta commented Mar 22, 2024

github-actions bot commented Mar 22, 2024

codecov bot commented Mar 22, 2024

Codecov Report

zelinh commented Mar 22, 2024

zelinh commented Mar 22, 2024

reta commented Mar 22, 2024 • edited Loading

reta commented Mar 22, 2024 •

edited

Loading

reta commented Mar 22, 2024 •

edited

Loading