Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [FEATURE] Broaden SecureSettingsFactory to include http transports (#12907) #12965

Merged

Conversation

reta
Copy link
Collaborator

@reta reta commented Mar 28, 2024

Backport of #12907 to 2.x

@peternied peternied changed the title [Backport] [2.x] [FEATURE] Broaden SecureSettingsFactory to include http transports (#12907) [Backport 2.x] [FEATURE] Broaden SecureSettingsFactory to include http transports (#12907) Mar 28, 2024
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 25f064c

Incompatible components

Incompatible components: [https://github.com/opensearch-project/security.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

✅ Gradle check result for 25f064c: SUCCESS

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 71.07%. Comparing base (0dd892c) to head (25f064c).
Report is 97 commits behind head on 2.x.

Files Patch % Lines
...tp/netty4/ssl/SecureNetty4HttpServerTransport.java 88.88% 2 Missing and 1 partial ⚠️
...a/org/opensearch/common/network/NetworkModule.java 94.11% 0 Missing and 1 partial ⚠️
...earch/plugins/SecureTransportSettingsProvider.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #12965      +/-   ##
============================================
- Coverage     71.28%   71.07%   -0.22%     
- Complexity    60145    60325     +180     
============================================
  Files          4957     4987      +30     
  Lines        282799   284501    +1702     
  Branches      41409    41599     +190     
============================================
+ Hits         201591   202195     +604     
- Misses        64189    65195    +1006     
- Partials      17019    17111      +92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peternied peternied merged commit 48881de into opensearch-project:2.x Mar 28, 2024
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants