-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce remote store hash algorithm in customData in IndexMetadata #12986
Conversation
Compatibility status:Checks if related components are compatible with change a91ed4d Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git] |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12986 +/- ##
============================================
- Coverage 71.42% 71.41% -0.01%
- Complexity 59978 60331 +353
============================================
Files 4985 5022 +37
Lines 282275 284178 +1903
Branches 40946 41157 +211
============================================
+ Hits 201603 202937 +1334
- Misses 63999 64399 +400
- Partials 16673 16842 +169 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ashish Singh <[email protected]>
❕ Gradle check result for a91ed4d: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
…search-project#12986) Signed-off-by: Ashish Singh <[email protected]>
…search-project#12986) Signed-off-by: Ashish Singh <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Signed-off-by: Ashish Singh <[email protected]> (cherry picked from commit 170ea7a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…search-project#12986) Signed-off-by: Ashish Singh <[email protected]>
…) (#13407) (cherry picked from commit 170ea7a) Signed-off-by: Ashish Singh <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…search-project#12986) Signed-off-by: Ashish Singh <[email protected]>
Description
This PR is a sub task of feature request #12567 and being tracked in meta issue - #12589.
This PR consists refactoring to introduce
path_hash_algorithm
inremote_store
customData in IndexMetadata. This will allow user to change the hashing algorithm used for generating the optimised remote store prefix once we add more algorithms. We also add FNV1a hash which we are planning to use for generating hashes for remote store optimised prefix.Related Issues
Resolves #12985
Check List
[ ] Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.