Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] FIX: UOE While building Exists query for nested search_as_you_type field #13006

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

msfroh
Copy link
Collaborator

@msfroh msfroh commented Apr 2, 2024

The "exists" query on an object field would fail when a "search_as_you_type" field is nested under that object.

It would also fail for a text field with prefixes enabled nested under the object, or any other field with a "hidden" subfield.


Signed-off-by: Mrudhul Guda [email protected]
(cherry picked from commit 37569ba)

Manual backport of #12048

Related Issues

Resolves #11821

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…eld (opensearch-project#12048)

The "exists" query on an object field would fail when a "search_as_you_type" field is nested under that object.

It would also fail for a text field with prefixes enabled nested under the object, or any other field with a
"hidden" subfield.

---------

Signed-off-by: Mrudhul Guda <[email protected]>
(cherry picked from commit 37569ba)
Copy link
Contributor

github-actions bot commented Apr 2, 2024

Compatibility status:

Checks if related components are compatible with change 80f59e7

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/sql.git]

Copy link
Contributor

github-actions bot commented Apr 2, 2024

❕ Gradle check result for 1dec5ce: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.cluster.coordination.AwarenessAttributeDecommissionIT.testConcurrentDecommissionAction

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 71.07%. Comparing base (0dd892c) to head (80f59e7).
Report is 161 commits behind head on 2.x.

❗ Current head 80f59e7 differs from pull request most recent head d4a088c. Consider uploading reports for the commit d4a088c to get more accurate results

Files Patch % Lines
...org/opensearch/index/query/ExistsQueryBuilder.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #13006      +/-   ##
============================================
- Coverage     71.28%   71.07%   -0.21%     
- Complexity    60145    60560     +415     
============================================
  Files          4957     5003      +46     
  Lines        282799   285267    +2468     
  Branches      41409    41709     +300     
============================================
+ Hits         201591   202755    +1164     
- Misses        64189    65406    +1217     
- Partials      17019    17106      +87     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

❌ Gradle check result for 80f59e7: TIMEOUT

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 80f59e7: SUCCESS

Copy link
Contributor

✅ Gradle check result for d4a088c: SUCCESS

@dblock dblock merged commit 3d26a6f into opensearch-project:2.x Apr 25, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers Search Search query, autocomplete ...etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants