-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update links to documentation in rest-api-spec #13043
Update links to documentation in rest-api-spec #13043
Conversation
Signed-off-by: Craig Perkins <[email protected]>
ca2fc23
to
00552fa
Compare
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
❌ Gradle check result for ca2fc23: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Compatibility status:Checks if related components are compatible with change c60746c Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git] |
❕ Gradle check result for 00552fa: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13043 +/- ##
============================================
- Coverage 71.42% 71.34% -0.08%
- Complexity 59978 60391 +413
============================================
Files 4985 5025 +40
Lines 282275 284381 +2106
Branches 40946 41188 +242
============================================
+ Hits 201603 202890 +1287
- Misses 63999 64738 +739
- Partials 16673 16753 +80 ☔ View full report in Codecov by Sentry. |
❕ Gradle check result for 9468cf2: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
❕ Gradle check result for 7f52e2e: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
❕ Gradle check result for c60746c: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
❕ Gradle check result for 00552fa: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Thanks a lot @cwperks ! |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-1.3 1.3
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-1.3
# Create a new branch
git switch --create backport/backport-13043-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d1239c3e41bb6974690602a7a783144f18993667
# Push it to GitHub
git push --set-upstream origin backport/backport-13043-to-1.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-1.3 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-1.x
# Create a new branch
git switch --create backport/backport-13043-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d1239c3e41bb6974690602a7a783144f18993667
# Push it to GitHub
git push --set-upstream origin backport/backport-13043-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-1.x Then, create a pull request where the |
* Update links to documentation in rest-api-spec Signed-off-by: Craig Perkins <[email protected]> * Remove changes in Debug_OpenSearch.xml Signed-off-by: Craig Perkins <[email protected]> * Remove changes in Debug_OpenSearch.xml Signed-off-by: Craig Perkins <[email protected]> * Add to CHANGELOG Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit d1239c3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@cwperks may I ask you please to backport this great change to |
* Update links to documentation in rest-api-spec * Remove changes in Debug_OpenSearch.xml * Remove changes in Debug_OpenSearch.xml * Add to CHANGELOG --------- (cherry picked from commit d1239c3) Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Does anyone know where we're still using this? I believe https://github.com/opensearch-project/opensearch-api-specification should now be at par. |
) * Update links to documentation in rest-api-spec Signed-off-by: Craig Perkins <[email protected]> * Remove changes in Debug_OpenSearch.xml Signed-off-by: Craig Perkins <[email protected]> * Remove changes in Debug_OpenSearch.xml Signed-off-by: Craig Perkins <[email protected]> * Add to CHANGELOG Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
Removes references to elastic documentation in rest-api-spec where documentation exists. I ran into issues updating all links because there are many undocumented APIs. Some of the undocumented APIs are not useful and there are comments in the specs mentioning that they are deprecated.
Missing Documentation:
Documentation exists, but not for specific API:
Documentation for PITs exists at https://opensearch.org/docs/latest/search-plugins/searching-data/point-in-time-api/, but could be organized in the broader API docs
Index Template APIs are under a route including im-plugin: https://opensearch.org/docs/latest/im-plugin/index-templates. Are these native APIs or are they provided by the ISM plugin?
Related Issues
Resolves #1339
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.