Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize remote state stale file deletion #13131

Merged
merged 24 commits into from
May 29, 2024

Conversation

shiv0408
Copy link
Member

@shiv0408 shiv0408 commented Apr 9, 2024

Description

Created an async task AsyncStaleFileDeletion which is initialized on only master eligible nodes. Once the task in initialized in RemoteClusterStateService start(), it schedules a clean up after specified interval which is added as a dynamic setting cluster.remote_store.state.cleanup_interval with 5 min default.
Clean up is also proceeded with if we have more than 10 successful states updates since last clean up. After trying clean up once, we schedule the task again after the set interval.

Related Issues

Resolves #12889
Resolves #12798 that test case is getting removed in this PR

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@shiv0408 shiv0408 added the backport 2.x Backport to 2.x branch label May 29, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13131-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b9befaa12524744ffe71d3f12699cb27cb8fca5e
# Push it to GitHub
git push --set-upstream origin backport/backport-13131-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-13131-to-2.x.

reta added a commit to reta/OpenSearch that referenced this pull request Jun 4, 2024
reta added a commit to reta/OpenSearch that referenced this pull request Jun 4, 2024
andrross pushed a commit that referenced this pull request Jun 4, 2024
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Jun 5, 2024
gaobinlong pushed a commit to gaobinlong/OpenSearch that referenced this pull request Jun 5, 2024
LantaoJin pushed a commit to LantaoJin/OpenSearch that referenced this pull request Jun 6, 2024
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
* Optimize remote state stale file deletion

Signed-off-by: Shivansh Arora <[email protected]>

* Added UT

Signed-off-by: Shivansh Arora <[email protected]>

* Refactored into a clean up manager file

Signed-off-by: Shivansh Arora <[email protected]>

* Add UT

Signed-off-by: Shivansh Arora <[email protected]>

* Modify the Integ test

Signed-off-by: Shivansh Arora <[email protected]>

* Address PR comment

Signed-off-by: Shivansh Arora <[email protected]>

* Add changelog

Signed-off-by: Shivansh Arora <[email protected]>

* apply spotless

Signed-off-by: Shivansh Arora <[email protected]>

* Made minor requested changes

Signed-off-by: Shivansh Arora <[email protected]>

* Fix default time interval

Signed-off-by: Shivansh Arora <[email protected]>

* Clean up global metadata attribute objects from remote

Signed-off-by: Shivansh Arora <[email protected]>

* fix build

Signed-off-by: Shivansh Arora <[email protected]>

* apply spotless

Signed-off-by: Shivansh Arora <[email protected]>

* remove MockAsyncUploadFSRepo to avoid flakiness

Signed-off-by: Shivansh Arora <[email protected]>

* apply spotless

Signed-off-by: Shivansh Arora <[email protected]>

---------

Signed-off-by: Shivansh Arora <[email protected]>
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
@shiv0408 shiv0408 self-assigned this Aug 5, 2024
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
* Optimize remote state stale file deletion

Signed-off-by: Shivansh Arora <[email protected]>

* Added UT

Signed-off-by: Shivansh Arora <[email protected]>

* Refactored into a clean up manager file

Signed-off-by: Shivansh Arora <[email protected]>

* Add UT

Signed-off-by: Shivansh Arora <[email protected]>

* Modify the Integ test

Signed-off-by: Shivansh Arora <[email protected]>

* Address PR comment

Signed-off-by: Shivansh Arora <[email protected]>

* Add changelog

Signed-off-by: Shivansh Arora <[email protected]>

* apply spotless

Signed-off-by: Shivansh Arora <[email protected]>

* Made minor requested changes

Signed-off-by: Shivansh Arora <[email protected]>

* Fix default time interval

Signed-off-by: Shivansh Arora <[email protected]>

* Clean up global metadata attribute objects from remote

Signed-off-by: Shivansh Arora <[email protected]>

* fix build

Signed-off-by: Shivansh Arora <[email protected]>

* apply spotless

Signed-off-by: Shivansh Arora <[email protected]>

* remove MockAsyncUploadFSRepo to avoid flakiness

Signed-off-by: Shivansh Arora <[email protected]>

* apply spotless

Signed-off-by: Shivansh Arora <[email protected]>

---------

Signed-off-by: Shivansh Arora <[email protected]>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments backport 2.x Backport to 2.x branch backport-failed bug Something isn't working Cluster Manager enhancement Enhancement or improvement to existing feature or request flaky-test Random test failure that succeeds on second run Storage:Remote v2.15.0 Issues and PRs related to version 2.15.0
Projects
Status: ✅ Done
Status: ✅ Done
5 participants