Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported version in yaml test file for the primary_only parameter in force-merge API #13279

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

gaobinlong
Copy link
Collaborator

@gaobinlong gaobinlong commented Apr 18, 2024

Description

In 2.13.0, we added a new parameter primary_only for the force-merge API in this PR:#11269, but I found that we omitted updating the supported version in a yaml test file when we updated the version check by this PR: #12657, so we need to update it.

Backport to 2.x is not needed, and changelog is also not needed.

Related Issues

#8021

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 4659b06: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 2ecef41: SUCCESS

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.42%. Comparing base (84679de) to head (2ecef41).

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13279      +/-   ##
============================================
- Coverage     71.48%   71.42%   -0.06%     
+ Complexity    60670    60654      -16     
============================================
  Files          5040     5040              
  Lines        285456   285456              
  Branches      41338    41338              
============================================
- Hits         204044   203882     -162     
- Misses        64589    64754     +165     
+ Partials      16823    16820       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta
Copy link
Collaborator

reta commented Apr 18, 2024

Thanks @gaobinlong !

@reta reta merged commit cdb57fa into opensearch-project:main Apr 18, 2024
41 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants