Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignoring unavailable shards during search request execution with igno… #13298

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

jainankitk
Copy link
Collaborator

…re_available parameter

Description

Better approach compared to #13209

Related Issues

Resolves #12371

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
    - [ ] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jainankitk jainankitk added the backport 2.x Backport to 2.x branch label Apr 19, 2024
Copy link
Contributor

❌ Gradle check result for 4cdb973: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 3f556a8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@jainankitk
Copy link
Collaborator Author

jainankitk commented Apr 19, 2024

Failing tests:

#12788

[Test Result](https://build.ci.opensearch.org/job/gradle-check/37351/testReport/) (1 failure / -3)

    [org.opensearch.indices.store.IndicesStoreIntegrationIT.testShardActiveElseWhere {p0={"cluster.remote_store.state.enabled":"true"}}](https://build.ci.opensearch.org/job/gradle-check/37351/testReport/junit/org.opensearch.indices.store/IndicesStoreIntegrationIT/testShardActiveElseWhere__p0___cluster_remote_store_state_enabled___true___/)

#13312

[Test Result](https://build.ci.opensearch.org/job/gradle-check/37349/testReport/) (1 failure / ±0)

    [org.opensearch.snapshots.DeleteSnapshotIT.testDeleteShallowCopySnapshot](https://build.ci.opensearch.org/job/gradle-check/37349/testReport/junit/org.opensearch.snapshots/DeleteSnapshotIT/testDeleteShallowCopySnapshot/)

@msfroh
Copy link
Collaborator

msfroh commented Apr 19, 2024

Looks good! I'm going to keep retrying Gradle checks until it passes.

Copy link
Contributor

✅ Gradle check result for 3f556a8: SUCCESS

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.40%. Comparing base (b15cb0c) to head (3f556a8).
Report is 197 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13298      +/-   ##
============================================
- Coverage     71.42%   71.40%   -0.02%     
- Complexity    59978    60646     +668     
============================================
  Files          4985     5039      +54     
  Lines        282275   285433    +3158     
  Branches      40946    41338     +392     
============================================
+ Hits         201603   203805    +2202     
- Misses        63999    64807     +808     
- Partials      16673    16821     +148     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jainankitk
Copy link
Collaborator Author

@msfroh - It seems the gradle check passed!

@dblock dblock merged commit 4e58cef into opensearch-project:main Apr 22, 2024
30 of 32 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 22, 2024
…re_available parameter (#13298)

Signed-off-by: Ankit Jain <[email protected]>
(cherry picked from commit 4e58cef)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
msfroh pushed a commit that referenced this pull request Apr 22, 2024
…re_available parameter (#13298) (#13326)

(cherry picked from commit 4e58cef)

Signed-off-by: Ankit Jain <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@jainankitk jainankitk deleted the oss-12371 branch April 22, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working Indexing & Search Search Search query, autocomplete ...etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Concurrent index deletion during ongoing search request throws 5xx error
4 participants