Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages for _stats with closed indices (#13012) #13338

Merged

Conversation

srikanthpadakanti
Copy link
Contributor

  • Improve the error messages for _stats with closed indices

Signed-off-by: srikanth padakanti [email protected]


Signed-off-by: Srikanth Padakanti [email protected]
(cherry picked from commit 98009ed)

Description

Improve the error messages for _stats with closed indices

Related Issues

Resolves #[https://github.com//issues/11180]

Check List

  • [ X] New functionality includes testing.
    • [ X] All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • [ X] Commits are signed per the DCO using --signoff
  • [ X] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • [ X] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…roject#13012)

* Improve the error messages for _stats with closed indices

Signed-off-by: srikanth padakanti <[email protected]>

* Edit the changelog text

Signed-off-by: srikanth padakanti <[email protected]>

* correct the test cases

Signed-off-by: srikanth padakanti <[email protected]>

* fix to throw appropriate error message

Signed-off-by: srikanth padakanti <[email protected]>

* fix to throw appropriate error message

Signed-off-by: srikanth padakanti <[email protected]>

---------

Signed-off-by: srikanth padakanti <[email protected]>
Signed-off-by: Srikanth Padakanti <[email protected]>
(cherry picked from commit 98009ed)
Copy link
Contributor

❕ Gradle check result for 910c66c: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteStoreStatsIT.testNonZeroPrimaryStatsOnNewlyCreatedIndexWithZeroDocs
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=indices.get_field_mapping/20_missing_field/Return empty object if field doesn't exist, but index does}

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 71.07%. Comparing base (0dd892c) to head (910c66c).
Report is 164 commits behind head on 2.x.

Files Patch % Lines
.../cluster/metadata/IndexNameExpressionResolver.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #13338      +/-   ##
============================================
- Coverage     71.28%   71.07%   -0.22%     
- Complexity    60145    60566     +421     
============================================
  Files          4957     5005      +48     
  Lines        282799   285471    +2672     
  Branches      41409    41737     +328     
============================================
+ Hits         201591   202896    +1305     
- Misses        64189    65434    +1245     
- Partials      17019    17141     +122     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mch2 mch2 merged commit 3956365 into opensearch-project:2.x Apr 23, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants