-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update supported version for the bug fix of from and size parameter can be negative when searching #13408
Conversation
…an be negative when searching Signed-off-by: Gao Binlong <[email protected]>
❕ Gradle check result for 1a11135: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
@gaobinlong rebase? The unrelated failure looks suspicious. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13408 +/- ##
============================================
+ Coverage 71.42% 71.51% +0.09%
- Complexity 59978 60784 +806
============================================
Files 4985 5045 +60
Lines 282275 286080 +3805
Branches 40946 41432 +486
============================================
+ Hits 201603 204593 +2990
- Misses 63999 64539 +540
- Partials 16673 16948 +275 ☔ View full report in Codecov by Sentry. |
@gaobinlong Can you please rebase again? I am not sure what's going on, @peterzhuamazon do you know? |
❌ Gradle check result for 835353f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Hi @dblock , thanks for your review and approval, but backport to 2.x branch is not needed because the supported version in 2.x branch is correct. |
…an be negative when searching (opensearch-project#13408) Signed-off-by: Gao Binlong <[email protected]>
…an be negative when searching (opensearch-project#13408) Signed-off-by: Gao Binlong <[email protected]>
…an be negative when searching (opensearch-project#13408) Signed-off-by: Gao Binlong <[email protected]>
Description
After the PR #13361 was backported to 2.x branch, we need to update the version check in main to ensure that the bwc tests can cover that bug fix.
Changelog is not needed, backport to 2.x is also not needed.
Related Issues
#11290
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.