Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to macos-13 runner for precommit and assemble github actions due to macos-latest is now arm64 #13412

Merged

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Apr 26, 2024

Description

Switch to macos-13 runner for precommit and assemble github actions due to macos-latest is now arm64

Related Issues

#13417

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 7d43a68: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@dblock
Copy link
Member

dblock commented Apr 26, 2024

Looks like assemble is failing on these?

@peterzhuamazon
Copy link
Member Author

Looks like assemble is failing on these?

The way to install docker has been limited on M123 apple silicon.
Trying to revert back to old x64 seems still having issues, will need to replace with the github actions.

Thanks.

Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
@gaiksaya
Copy link
Member

gaiksaya commented Apr 26, 2024

As per the conversation on this issue actions/runner-images#9254 looks like docker is not supported on M1 runners.Something to note once we decide to upgrade

@peterzhuamazon
Copy link
Member Author

As per the conversation on this issue actions/runner-images#9254 looks like docker is not supported on M1 runners.Something to note once we decide to upgrade

macos-14 has x64 version but right now their docs website and their github readme is conflicting with each other on the tag naming. Will keep macos-13 for now as that is 100% x64.

Thanks.

@peterzhuamazon peterzhuamazon marked this pull request as ready for review April 26, 2024 21:21
Copy link
Contributor

❕ Gradle check result for d0ee653: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@owaiskazi19
Copy link
Member

@peterzhuamazon can we have an issue to switch to macos-latest in the future?

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.50%. Comparing base (b15cb0c) to head (97390df).
Report is 227 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13412      +/-   ##
============================================
+ Coverage     71.42%   71.50%   +0.08%     
- Complexity    59978    60823     +845     
============================================
  Files          4985     5045      +60     
  Lines        282275   286068    +3793     
  Branches      40946    41431     +485     
============================================
+ Hits         201603   204547    +2944     
- Misses        63999    64604     +605     
- Partials      16673    16917     +244     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

✅ Gradle check result for 5cf11f8: SUCCESS

Copy link
Contributor

❕ Gradle check result for 41854a5: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.http.SearchRestCancellationIT.testAutomaticCancellationDuringQueryPhase
      1 org.opensearch.http.SearchRestCancellationIT.testAutomaticCancellationDuringFetchPhase

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@peterzhuamazon
Copy link
Member Author

@peterzhuamazon can we have an issue to switch to macos-latest in the future?

Copy link
Contributor

✅ Gradle check result for 97390df: SUCCESS

@sachinpkale sachinpkale merged commit 207bbad into opensearch-project:main Apr 27, 2024
38 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 27, 2024
…ue to macos-latest is now arm64 (#13412)

* Switch to macos-13 for precommit and assemble due to macos-latest is now arm64

Signed-off-by: Peter Zhu <[email protected]>

* Update changelog

Signed-off-by: Peter Zhu <[email protected]>

* Add action

Signed-off-by: Peter Zhu <[email protected]>

* Add action

Signed-off-by: Peter Zhu <[email protected]>

* more changes

Signed-off-by: Peter Zhu <[email protected]>

* Remove colima start command as action already start it

Signed-off-by: Peter Zhu <[email protected]>

---------

Signed-off-by: Peter Zhu <[email protected]>
(cherry picked from commit 207bbad)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sachinpkale pushed a commit that referenced this pull request Apr 27, 2024
…ue to macos-latest is now arm64 (#13412) (#13420)

* Switch to macos-13 for precommit and assemble due to macos-latest is now arm64



* Update changelog



* Add action



* Add action



* more changes



* Remove colima start command as action already start it



---------


(cherry picked from commit 207bbad)

Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@peterzhuamazon peterzhuamazon deleted the macos-runner-change branch April 29, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch enhancement Enhancement or improvement to existing feature or request
Projects
Development

Successfully merging this pull request may close these issues.

6 participants