-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] [Tiered Caching] Expose new cache stats API (#13237) #13456
[Backport 2.x] [Tiered Caching] Expose new cache stats API (#13237) #13456
Conversation
Step 3 out of 4 --------- Signed-off-by: Peter Alfonsi <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]> (cherry picked from commit 2a37bdd)
Signed-off-by: Peter Alfonsi <[email protected]>
Signed-off-by: Peter Alfonsi <[email protected]>
bc553c7
to
474c19f
Compare
❌ Gradle check result for bc553c7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 3030b81: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 474c19f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Peter Alfonsi <[email protected]>
❌ Gradle check result for 1e04ce5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Peter Alfonsi <[email protected]>
❕ Gradle check result for 1f24c30: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Original PR: #13237
Note: I have changed V_3_0_0 to V_2_14_0 in the relevant places for this backport, and added TODOs to change this value to V_2_14_0 in main in the future.
Description
This change exposes a new cache stats API described in this issue. Currently the only supported
<cache_type>
parameter isrequest_cache
, but more can be added easily. This API supports stats aggregation by arbitrary dimensions, which are stored in the keys (ICacheKey objects) that are passed to ICache implementations. In the IRC, these dimensions are "indices", "shards", and "tier" (if a TieredSpilloverCache is used as the cache implementation, see #13236).Tested manually and with an IT to check aggregation by various levels in the IRC.
No public doc PR for now, as the tiered caching feature is not yet complete and we are waiting to add doc PRs until it's fully ready for use.
Related Issues
Part of #12258
Check List
- [N/A] Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.