Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.14] Support multi ranges traversal when doing date histogram rewrite optimization (#13317) #13533

Merged
merged 2 commits into from
May 3, 2024

Conversation

bowenlan-amzn
Copy link
Member

@bowenlan-amzn bowenlan-amzn commented May 3, 2024

Description

Manually cut this backport from #13522, just to start the gradle check, reducing wait time

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…mization (opensearch-project#13317)

Signed-off-by: bowenlan-amzn <[email protected]>

remove unnecessary change log

Signed-off-by: bowenlan-amzn <[email protected]>
Copy link
Contributor

github-actions bot commented May 3, 2024

❕ Gradle check result for ce9a751: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=indices.get_field_mapping/20_missing_field/Return empty object if field doesn't exist, but index does}

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented May 3, 2024

Codecov Report

Attention: Patch coverage is 81.12245% with 37 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (2.14@d160ecb). Click here to learn what that means.

Files Patch % Lines
...h/aggregations/bucket/FastFilterRewriteHelper.java 88.82% 8 Missing and 11 partials ⚠️
.../bucket/histogram/AutoDateHistogramAggregator.java 22.22% 7 Missing ⚠️
...egations/bucket/composite/CompositeAggregator.java 40.00% 6 Missing ⚠️
...ions/bucket/histogram/DateHistogramAggregator.java 28.57% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             2.14   #13533   +/-   ##
=======================================
  Coverage        ?   71.34%           
  Complexity      ?    61178           
=======================================
  Files           ?     5026           
  Lines           ?   287588           
  Branches        ?    42036           
=======================================
  Hits            ?   205190           
  Misses          ?    65118           
  Partials        ?    17280           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbwiddis dbwiddis merged commit 15df1e8 into opensearch-project:2.14 May 3, 2024
52 checks passed
@bowenlan-amzn bowenlan-amzn deleted the backport13317to2.14 branch May 3, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants