-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Remote Store] Upload translog checkpoint as object metadata to translog #13637
Conversation
❌ Gradle check result for c20ae47: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Sandeep Kumawat <[email protected]>
❌ Gradle check result for 6724043: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for b07035e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Sandeep Kumawat <[email protected]>
❌ Gradle check result for fc368da: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
plugins/repository-s3/src/main/java/org/opensearch/repositories/s3/S3BlobStore.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/common/settings/ClusterSettings.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/remote/RemoteStoreCustomMetadataResolver.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/remote/RemoteStoreEnums.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/indices/RemoteStoreSettings.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/translog/transfer/TransferService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/translog/transfer/TransferSnapshot.java
Outdated
Show resolved
Hide resolved
❌ Gradle check result for 7586b7d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Sandeep Kumawat <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13637-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 76e2a5d9d70ab310033f33151fdaa0ab68c6537e
# Push it to GitHub
git push --set-upstream origin backport/backport-13637-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…log (opensearch-project#13637) * Upload translog checkpoint as object metadata to translog Signed-off-by: Sandeep Kumawat <[email protected]>
…log (opensearch-project#13637) * Upload translog checkpoint as object metadata to translog Signed-off-by: Sandeep Kumawat <[email protected]>
…log (#13637) (#13795) * Upload translog checkpoint as object metadata to translog Signed-off-by: Sandeep Kumawat <[email protected]>
…log (opensearch-project#13637) * Upload translog checkpoint as object metadata to translog Signed-off-by: Sandeep Kumawat <[email protected]>
…log (opensearch-project#13637) (opensearch-project#13795) * Upload translog checkpoint as object metadata to translog Signed-off-by: Sandeep Kumawat <[email protected]> Signed-off-by: kkewwei <[email protected]>
Previous PR link: #13272
Description
This PR is a sub task of feature request #13022. And is being tracked here #13091.
This PR include below changes -
translog-metadata
) in remote store custom metadata for new indices.translog-metadata
as true, the translog.ckp file's data is now stored as object metadata associated with the translog.tlog file when uploading to an S3 remote storage.Related Issues
Resolves #13094
Check List
Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.