[Backport 2.x] Abstracting outbound side of transport (#13293) #13656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Abstracting outbound side of transport Signed-off-by: Vacha Shah <[email protected]> * Making outbound handler protocol dependent via inbound handler Signed-off-by: Vacha Shah <[email protected]> * Fixing precommit Signed-off-by: Vacha Shah <[email protected]> * Addressing comments Signed-off-by: Vacha Shah <[email protected]> * Fixing precommit Signed-off-by: Vacha Shah <[email protected]> * Cleaning up code Signed-off-by: Vacha Shah <[email protected]> * Addressing comments Signed-off-by: Vacha Shah <[email protected]> * Cleaning up Signed-off-by: Vacha Shah <[email protected]> * Addressing comments Signed-off-by: Vacha Shah <[email protected]> * Abstracting InboundHandlerTests Signed-off-by: Vacha Shah <[email protected]> * Abstracting TransportLoggerTests Signed-off-by: Vacha Shah <[email protected]> --------- Signed-off-by: Vacha Shah <[email protected]>
VachaShah
requested review from
peternied,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
tlfeng
as code owners
8 tasks
reta
approved these changes
May 13, 2024
|
❌ Gradle check result for 6b356e5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #13656 +/- ##
============================================
+ Coverage 71.28% 71.30% +0.02%
- Complexity 60145 61209 +1064
============================================
Files 4957 5030 +73
Lines 282799 287818 +5019
Branches 41409 42072 +663
============================================
+ Hits 201591 205239 +3648
- Misses 64189 65240 +1051
- Partials 17019 17339 +320 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstracting outbound side of transport
Making outbound handler protocol dependent via inbound handler
Fixing precommit
Addressing comments
Fixing precommit
Cleaning up code
Addressing comments
Cleaning up
Addressing comments
Abstracting InboundHandlerTests
Abstracting TransportLoggerTests
Description
Backport #13293 to 2.x
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.