[Backport 2.14] Check changed files before running gradle check

[opensearch-trigger-bot]

Backport 0c0a2b3 from #13498.

[github-actions]

❌ Gradle check result for ffa13eb: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[reta]

❌ Gradle check result for ffa13eb: FAILURE

#13504, fixed by not backported

[github-actions]

❌ Gradle check result for ffa13eb: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for ffa13eb: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for ffa13eb: ABORTED

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❕ Gradle check result for ffa13eb: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[github-actions]

✅ Gradle check result for a9ff2bf: SUCCESS

[reta]

@prudhvigodithi apologies, may I ask you for approve + force merge here, the change backports check-result check (but it is being awaited for since it is not in the workflows), thank you

[prudhvigodithi]

Thanks @reta I understand for check-result, @peternied do yo know why this Minimum approval count is not triggered?

[reta]

@peternied do yo know why this Minimum approval count is not triggered?

@prudhvigodithi it is triggered, the pull request was rebased and needs reapproval, you could approve it (or any other maintainer), I pinged you since forced merge is needed anyway ;-)

[peternied]

do yo know why this Minimum approval count is not triggered?

@prudhvigodithi Yes the way GHA checks are triggered can come from several sources, most often we see pull_request as the trigger source, but for the minimum approver count this comes from contributors / maintainers submitting a 'review' on the change [1] which includes a comment/approval/request changes state. If there is no review on the latest version of the change to merge the check will wait.

The user experience could be improved by using an App which depends on external infrastructure and we just saw how that turned out :doh:

• [1] See the workflow definition https://github.com/opensearch-project/OpenSearch/actions/runs/9374472213/workflow?pr=13952

[prudhvigodithi]

I mean the Minimum approval count is already stratified, but expected for an approval again since there was a force push.