-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DCO workflow until dcoapp/app issue is fixed #13970
Conversation
Signed-off-by: Prudhvi Godithi <[email protected]>
@prudhvigodithi A short term alternative is to remove the required check and have maintainers manually verify that commits are signed. That might be less intrusive if we don't plan to keep this version of the check. What do you think? |
@andrross I think workflow is an acceptable alternative to keep (instead of app that proves to be unstable) for good. |
Luckily we've already got this workflow, I would rather have machines read every commit and return a ✅ or ❌ on each PR than train myself to do this repetitive task. |
@prudhvigodithi we are all set, but needs forced merge |
Let me force merge this PR and once the backports are done I will update the branch rule to point to this new DCO workflow. |
293905a
into
opensearch-project:main
Signed-off-by: Prudhvi Godithi <[email protected]> (cherry picked from commit 293905a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Prudhvi Godithi <[email protected]> (cherry picked from commit 293905a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Prudhvi Godithi <[email protected]> (cherry picked from commit 293905a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Prudhvi Godithi <[email protected]> (cherry picked from commit 293905a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 293905a) Signed-off-by: Prudhvi Godithi <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 293905a) Signed-off-by: Prudhvi Godithi <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 293905a) Signed-off-by: Prudhvi Godithi <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 293905a) Signed-off-by: Prudhvi Godithi <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Prudhvi Godithi <[email protected]>
Signed-off-by: Prudhvi Godithi <[email protected]>
Signed-off-by: Prudhvi Godithi <[email protected]>
Signed-off-by: Prudhvi Godithi <[email protected]>
(cherry picked from commit 293905a) Signed-off-by: Prudhvi Godithi <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: kkewwei <[email protected]>
Signed-off-by: Prudhvi Godithi <[email protected]>
Description
Looks like the DCO app issue may take some time to get fully fixed dcoapp/app#211 (comment), for temporary fix we can use https://github.com/tim-actions/dco to run the DCO checks. We have used this in past for job-scheduler repo https://github.com/opensearch-project/job-scheduler/tree/1.3.16.0/.github/workflows, this should unblock the open PR's with mandatory DCO branch rule.
Related Issues
Check List
New functionality includes testing.New functionality has been documented.New functionality has javadoc addedAPI changes companion pull request created.Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)Commit changes are listed out in CHANGELOG.md file (See: Changelog)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.