Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DCO workflow until dcoapp/app issue is fixed #13970

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

prudhvigodithi
Copy link
Contributor

@prudhvigodithi prudhvigodithi commented Jun 4, 2024

Description

Looks like the DCO app issue may take some time to get fully fixed dcoapp/app#211 (comment), for temporary fix we can use https://github.com/tim-actions/dco to run the DCO checks. We have used this in past for job-scheduler repo https://github.com/opensearch-project/job-scheduler/tree/1.3.16.0/.github/workflows, this should unblock the open PR's with mandatory DCO branch rule.

Related Issues

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • API changes companion pull request created.
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@prudhvigodithi prudhvigodithi changed the title Add DCO workflow Add DCO workflow until dcoapp/app issue is fixed Jun 4, 2024
@prudhvigodithi prudhvigodithi marked this pull request as draft June 4, 2024 18:43
@prudhvigodithi prudhvigodithi added backport 1.x backport 2.x Backport to 2.x branch backport 1.3 Backport to 1.3 branch backport 2.14 Backport to 2.14 branch and removed >FORK Related to the fork process Priority-Medium distributed framework labels Jun 4, 2024
Signed-off-by: Prudhvi Godithi <[email protected]>
@peternied peternied marked this pull request as ready for review June 4, 2024 19:20
@github-actions github-actions bot added bug Something isn't working cicd Other labels Jun 4, 2024
@andrross
Copy link
Member

andrross commented Jun 4, 2024

@prudhvigodithi A short term alternative is to remove the required check and have maintainers manually verify that commits are signed. That might be less intrusive if we don't plan to keep this version of the check. What do you think?

@reta
Copy link
Collaborator

reta commented Jun 4, 2024

@prudhvigodithi A short term alternative is to remove the required check and have maintainers manually verify that commits are signed. That might be less intrusive if we don't plan to keep this version of the check. What do you think?

@andrross I think workflow is an acceptable alternative to keep (instead of app that proves to be unstable) for good.

@peternied
Copy link
Member

peternied commented Jun 4, 2024

A short term alternative is to remove the required check and have maintainers manually verify that commits are signed. That might be less intrusive if we don't plan to keep this version of the check. What do you think?

Luckily we've already got this workflow, I would rather have machines read every commit and return a ✅ or ❌ on each PR than train myself to do this repetitive task.

@reta
Copy link
Collaborator

reta commented Jun 4, 2024

@prudhvigodithi we are all set, but needs forced merge

@prudhvigodithi
Copy link
Contributor Author

Let me force merge this PR and once the backports are done I will update the branch rule to point to this new DCO workflow.

@prudhvigodithi prudhvigodithi merged commit 293905a into opensearch-project:main Jun 4, 2024
39 of 43 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 4, 2024
Signed-off-by: Prudhvi Godithi <[email protected]>
(cherry picked from commit 293905a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 4, 2024
Signed-off-by: Prudhvi Godithi <[email protected]>
(cherry picked from commit 293905a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 4, 2024
Signed-off-by: Prudhvi Godithi <[email protected]>
(cherry picked from commit 293905a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 4, 2024
Signed-off-by: Prudhvi Godithi <[email protected]>
(cherry picked from commit 293905a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
prudhvigodithi pushed a commit that referenced this pull request Jun 4, 2024
(cherry picked from commit 293905a)

Signed-off-by: Prudhvi Godithi <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
prudhvigodithi pushed a commit that referenced this pull request Jun 4, 2024
(cherry picked from commit 293905a)

Signed-off-by: Prudhvi Godithi <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
prudhvigodithi pushed a commit that referenced this pull request Jun 4, 2024
(cherry picked from commit 293905a)

Signed-off-by: Prudhvi Godithi <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
prudhvigodithi pushed a commit that referenced this pull request Jun 4, 2024
(cherry picked from commit 293905a)

Signed-off-by: Prudhvi Godithi <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Jun 5, 2024
gaobinlong pushed a commit to gaobinlong/OpenSearch that referenced this pull request Jun 5, 2024
LantaoJin pushed a commit to LantaoJin/OpenSearch that referenced this pull request Jun 6, 2024
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
(cherry picked from commit 293905a)

Signed-off-by: Prudhvi Godithi <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: kkewwei <[email protected]>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.x backport 1.3 Backport to 1.3 branch backport 2.x Backport to 2.x branch backport 2.14 Backport to 2.14 branch bug Something isn't working cicd distributed framework >FORK Related to the fork process Other Priority-Medium skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] DCO check is not running for recent PRs DCO check stays as expected
4 participants