Fix double invocation of postCollection when MultiBucketCollector is present #14015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jed326
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
tlfeng and
VachaShah
as code owners
github-actions
bot
added
bug
…present Signed-off-by: Jay Deng <[email protected]>
|
❌ Gradle check result for 2d9e52d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
@sohami @reta @dennisoelkers could you please take a look? Thanks! |
|
❌ Gradle check result for 9b2ebbd: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14015 +/- ##
============================================
+ Coverage 71.42% 71.56% +0.13%
- Complexity 59978 61344 +1366
============================================
Files 4985 5066 +81
Lines 282275 288263 +5988
Branches 40946 41754 +808
============================================
+ Hits 201603 206281 +4678
- Misses 63999 64963 +964
- Partials 16673 17019 +346 ☔ View full report in Codecov by Sentry. |
|
@jed326: Tested it locally and it fixes the problem. Great work! Many thanks for the quick investigation and fix, as well as providing a workaround for 2.14! |
dennisoelkers
approved these changes
Jun 6, 2024
reta
reviewed
Jun 6, 2024
server/src/main/java/org/opensearch/search/aggregations/BucketCollectorProcessor.java
Show resolved
Hide resolved
reta
approved these changes
Jun 6, 2024
|
Thank you @jed326 ! |
sohami
reviewed
Jun 6, 2024
...r/src/main/java/org/opensearch/search/aggregations/bucket/BestBucketsDeferringCollector.java
Show resolved
Hide resolved
reta
approved these changes
Jun 6, 2024
sohami
approved these changes
Jun 6, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 6, 2024
…present (#14015) Signed-off-by: Jay Deng <[email protected]> (cherry picked from commit 1cded65) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jed326
pushed a commit
that referenced
this pull request
Jun 6, 2024
…present (#14015) Signed-off-by: Jay Deng <[email protected]> (cherry picked from commit 1cded65) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jed326
pushed a commit
that referenced
this pull request
Jun 7, 2024
…present (#14015) Signed-off-by: Jay Deng <[email protected]> (cherry picked from commit 1cded65) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
pushed a commit
that referenced
this pull request
Jun 7, 2024
…present (#14015) (#14048) (cherry picked from commit 1cded65) Signed-off-by: Jay Deng <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
parv0201
pushed a commit
to parv0201/OpenSearch
that referenced
this pull request
Jun 10, 2024
…present (opensearch-project#14015) Signed-off-by: Jay Deng <[email protected]>
3 tasks
kkewwei
pushed a commit
to kkewwei/OpenSearch
that referenced
this pull request
Jul 24, 2024
…present (opensearch-project#14015) (opensearch-project#14048) (cherry picked from commit 1cded65) Signed-off-by: Jay Deng <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: kkewwei <[email protected]>
wdongyu
pushed a commit
to wdongyu/OpenSearch
that referenced
this pull request
Aug 22, 2024
…present (opensearch-project#14015) Signed-off-by: Jay Deng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where
postCollectionwould be called twice when aMultiBucketCollectoris present. This was resulting in double counting the docs in the last segment for deferred bucket collectors.Related Issues
Resolves #14000
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.