-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Remote Store] Add support to disable flush based on translog reader count #14027
[Remote Store] Add support to disable flush based on translog reader count #14027
Conversation
Signed-off-by: Shourya Dutta Biswas <[email protected]>
Signed-off-by: Shourya Dutta Biswas <[email protected]>
❌ Gradle check result for 5679151: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14027 +/- ##
============================================
+ Coverage 71.42% 71.58% +0.16%
- Complexity 59978 61368 +1390
============================================
Files 4985 5071 +86
Lines 282275 288396 +6121
Branches 40946 41766 +820
============================================
+ Hits 201603 206459 +4856
- Misses 63999 64888 +889
- Partials 16673 17049 +376 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM.
Signed-off-by: Shourya Dutta Biswas <[email protected]>
❕ Gradle check result for 75e28a9: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-14027-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b9ca5a8e24673ed38cab736ffbd57479de241553
# Push it to GitHub
git push --set-upstream origin backport/backport-14027-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…count (opensearch-project#14027) Signed-off-by: Shourya Dutta Biswas <[email protected]>
…count (#14027) (#14044) Signed-off-by: Shourya Dutta Biswas <[email protected]>
…count (opensearch-project#14027) Signed-off-by: Shourya Dutta Biswas <[email protected]>
…count (opensearch-project#14027) (opensearch-project#14044) Signed-off-by: Shourya Dutta Biswas <[email protected]> Signed-off-by: kkewwei <[email protected]>
…count (opensearch-project#14027) Signed-off-by: Shourya Dutta Biswas <[email protected]>
Description
We introduced ability to run flush automatically based on the number of accumulated translog readers. With this PR, we are
-1
as a permissible value for the settingcluster.remote_store.translog.max_readers
which would disable this feature.This is needed to prevent repeated flushes when a large number of translog files get accumulated, especially when a shard copy is relocating to another node and the active primary is getting large number of writes. This also helps during the remotestore migration when the remote seeding process ends up accumulating a lot of translog on the active primary which needs to be replayed after the seeding process is complete.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
API changes companion pull request created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.