Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add X-Opaque-Id to search request metadata for query insights (#13374) #14078

Merged

Conversation

ansjcy
Copy link
Member

@ansjcy ansjcy commented Jun 7, 2024

Manual backport PR for #13374

(cherry picked from commit 9d3cf43)

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…arch-project#13374)

---------

Signed-off-by: Chenyang Ji <[email protected]>
(cherry picked from commit 9d3cf43)
Signed-off-by: Chenyang Ji <[email protected]>
Copy link
Contributor

github-actions bot commented Jun 7, 2024

❕ Gradle check result for dcb30c3: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.

Project coverage is 71.39%. Comparing base (0dd892c) to head (dcb30c3).
Report is 315 commits behind head on 2.x.

Files Patch % Lines
...action/search/SearchRequestOperationsListener.java 0.00% 3 Missing ⚠️
.../insights/core/listener/QueryInsightsListener.java 80.00% 0 Missing and 1 partial ⚠️
...opensearch/action/search/SearchRequestContext.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #14078      +/-   ##
============================================
+ Coverage     71.28%   71.39%   +0.11%     
- Complexity    60145    61497    +1352     
============================================
  Files          4957     5045      +88     
  Lines        282799   289021    +6222     
  Branches      41409    42211     +802     
============================================
+ Hits         201591   206359    +4768     
- Misses        64189    65287    +1098     
- Partials      17019    17375     +356     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jed326
jed326 previously approved these changes Jun 7, 2024
Copy link
Collaborator

@jed326 jed326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be causing any of the test failures as all the changes are in the query plugins insight which isn't being enabled in the tests. The culprit is probably this one: #13172

@jed326 jed326 merged commit 34af8c7 into opensearch-project:2.x Jun 7, 2024
53 of 55 checks passed
@ansjcy
Copy link
Member Author

ansjcy commented Jun 8, 2024

Fixed the test failure in #14084

kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants