Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test IndicesRequestCacheIT.testDeleteAndCreateSameIndexShardOnSameNode #14090

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

kkewwei
Copy link
Contributor

@kkewwei kkewwei commented Jun 8, 2024

Signed-off-by: kkewwei [email protected]

Description

[BUG] org.opensearch.indices.IndicesRequestCacheIT.testDeleteAndCreateSameIndexShardOnSameNode is flaky

Related Issues

Resolves #13600

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Jun 8, 2024

❌ Gradle check result for 81fbf75: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 8, 2024

✅ Gradle check result for b5022a8: SUCCESS

Copy link

codecov bot commented Jun 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.81%. Comparing base (b15cb0c) to head (b5022a8).
Report is 378 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #14090      +/-   ##
============================================
+ Coverage     71.42%   71.81%   +0.39%     
- Complexity    59978    61652    +1674     
============================================
  Files          4985     5081      +96     
  Lines        282275   289059    +6784     
  Branches      40946    41835     +889     
============================================
+ Hits         201603   207588    +5985     
- Misses        63999    64341     +342     
- Partials      16673    17130     +457     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kkewwei
Copy link
Contributor Author

kkewwei commented Jun 8, 2024

@reta please have a look when you are free.

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for picking this up.

@dblock dblock added the backport 2.x Backport to 2.x branch label Jun 10, 2024
@dblock dblock merged commit c639e9a into opensearch-project:main Jun 10, 2024
34 of 35 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 10, 2024
…dOnSameNode (#14090)

Signed-off-by: kkewwei [email protected]

Signed-off-by: kkewwei [email protected]
Signed-off-by: kkewwei <[email protected]>
(cherry picked from commit c639e9a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
@kkewwei kkewwei deleted the issue_13600 branch June 11, 2024 05:56
kotwanikunal pushed a commit that referenced this pull request Jun 11, 2024
…dOnSameNode (#14090) (#14124)

Signed-off-by: kkewwei [email protected]

Signed-off-by: kkewwei [email protected]

(cherry picked from commit c639e9a)

Signed-off-by: kkewwei [email protected]
Signed-off-by: kkewwei <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@sgup432
Copy link
Contributor

sgup432 commented Jun 11, 2024

@kkewwei Thanks for picking this up! Considering this test is already fixed, can we also remove the AwaitsFix annotation here?

kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
…dOnSameNode (opensearch-project#14090) (opensearch-project#14124)

Signed-off-by: kkewwei [email protected]

Signed-off-by: kkewwei [email protected]

(cherry picked from commit c639e9a)

Signed-off-by: kkewwei [email protected]
Signed-off-by: kkewwei <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: kkewwei <[email protected]>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working flaky-test Random test failure that succeeds on second run Search:Performance Search Search query, autocomplete ...etc skip-changelog
Projects
None yet
3 participants