Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Remote Store Migration from DocRep to GA #14100

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

gbbafna
Copy link
Collaborator

@gbbafna gbbafna commented Jun 9, 2024

Description

Move Remote Store Migration from DocRep to GA and update migration setting names.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • [] API changes companion pull request created, if applicable.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Jun 9, 2024

❌ Gradle check result for a3c7980: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 9, 2024

❌ Gradle check result for 235cce8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Modify remote store migration setting name.

Signed-off-by: Gaurav Bafna <[email protected]>
Copy link
Contributor

❌ Gradle check result for 3b3a948: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Gaurav Bafna <[email protected]>
@gbbafna gbbafna requested a review from VachaShah as a code owner June 10, 2024 06:34
Copy link
Contributor

❌ Gradle check result for 18375ff: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 18375ff: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 18375ff: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 18375ff: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Gaurav Bafna <[email protected]>
Copy link
Contributor

✅ Gradle check result for 9df19e5: SUCCESS

@sachinpkale sachinpkale merged commit 694a8e2 into opensearch-project:main Jun 10, 2024
28 of 35 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-14100-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 694a8e28cea2e80438ab1be98a1c2f8d866a2d4a
# Push it to GitHub
git push --set-upstream origin backport/backport-14100-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-14100-to-2.x.

@gbbafna gbbafna deleted the migration-ga branch June 10, 2024 12:51
gbbafna added a commit to gbbafna/OpenSearch that referenced this pull request Jun 10, 2024
Signed-off-by: Gaurav Bafna <[email protected]>

---------

Signed-off-by: Gaurav Bafna <[email protected]>
gbbafna added a commit that referenced this pull request Jun 10, 2024
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
* Move Remote Store Migration from DocRep to GA.
Modify remote store migration setting name.

Signed-off-by: Gaurav Bafna <[email protected]>

* Modify changelog

Signed-off-by: Gaurav Bafna <[email protected]>

* fixing a test

Signed-off-by: Gaurav Bafna <[email protected]>

---------

Signed-off-by: Gaurav Bafna <[email protected]>
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
* Move Remote Store Migration from DocRep to GA.
Modify remote store migration setting name.

Signed-off-by: Gaurav Bafna <[email protected]>

* Modify changelog

Signed-off-by: Gaurav Bafna <[email protected]>

* fixing a test

Signed-off-by: Gaurav Bafna <[email protected]>

---------

Signed-off-by: Gaurav Bafna <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants