Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

limit the max value of cluster.max_shards_per_node to avoid int overflow #14155

Merged
merged 2 commits into from
Jun 20, 2024
Merged

limit the max value of cluster.max_shards_per_node to avoid int overflow #14155

merged 2 commits into from
Jun 20, 2024

Conversation

kkewwei
Copy link
Contributor

@kkewwei kkewwei commented Jun 11, 2024 •
edited
Loading

Signed-off-by: kkewwei [email protected]

Description

Limit the max value of cluster.max_shards_per_node to avoid int overflow. We can't reach 1_500_000 in the current opensearch struct.

Related Issues

Resolves #13907

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added bug Something isn't working Cluster Manager labels Jun 11, 2024
@kkewwei kkewwei force-pushed the pr_13907 branch 2 times, most recently from f73f384 to 730b329 Compare June 11, 2024 01:25
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for f73f384: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 730b329: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 3616d55: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for b49cd2e: SUCCESS

@kkewwei
Copy link
Contributor Author

kkewwei commented Jun 12, 2024

@dblock @shwetathareja please have another look.

@dblock
Copy link
Member

dblock commented Jun 12, 2024

@shwetathareja leaving this to you, LGTM

@dblock dblock added the >breaking Identifies a breaking change. label Jun 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for b2cf752: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei
Copy link
Contributor Author

kkewwei commented Jun 12, 2024

❌ Gradle check result for b2cf752: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

ReindexBasicTests.testMultipleSources #13913

shwetathareja
shwetathareja reviewed Jun 13, 2024
View reviewed changes
Copy link
Member

@shwetathareja shwetathareja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kkewwei , minor comment otherwise looks good.

server/src/main/java/org/opensearch/indices/ShardLimitValidator.java Show resolved Hide resolved
This was referenced Jun 13, 2024
Open
Open
Open
Open
Open
Open
@kkewwei
Copy link
Contributor Author

kkewwei commented Jun 17, 2024

@shwetathareja please see again.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for b2cf752: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shwetathareja
Copy link
Member

@kkewwei please fix the conflict in ChangeLog.md

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for b2cf752: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for bda874c: SUCCESS

@shwetathareja shwetathareja merged commit 761e207 into opensearch-project:main Jun 20, 2024
31 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 20, 2024
@github-actions
Fix the computed max shards of cluster to avoid int overflow (#14155)
0971e61 
Signed-off-by: kkewwei <[email protected]>
(cherry picked from commit 761e207)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jun 20, 2024
Merged
dblock pushed a commit that referenced this pull request Jun 20, 2024
@opensearch-trigger-bot @github-actions
Fix the computed max shards of cluster to avoid int overflow (#14155) (…
29ac578 
…#14474)

(cherry picked from commit 761e207)

Signed-off-by: kkewwei <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@kkewwei kkewwei deleted the pr_13907 branch June 21, 2024 03:07
harshavamsi pushed a commit to harshavamsi/OpenSearch that referenced this pull request Jul 12, 2024
@kkewwei @harshavamsi
Fix the computed max shards of cluster to avoid int overflow (opensea…
ad95677 
…rch-project#14155)

Signed-off-by: kkewwei <[email protected]>
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
@opensearch-trigger-bot @github-actions @kkewwei
Fix the computed max shards of cluster to avoid int overflow (opensea…
cd323b0 
…rch-project#14155) (opensearch-project#14474)

(cherry picked from commit 761e207)

Signed-off-by: kkewwei <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: kkewwei <[email protected]>
@BrewTestBot BrewTestBot mentioned this pull request Aug 8, 2024
Merged
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
@kkewwei
Fix the computed max shards of cluster to avoid int overflow (opensea…
a50acc3 
…rch-project#14155)

Signed-off-by: kkewwei <[email protected]>
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock left review comments

@rajiv-kv rajiv-kv rajiv-kv left review comments

@shwetathareja shwetathareja shwetathareja approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch >breaking Identifies a breaking change. bug Something isn't working Cluster Manager
Projects
Cluster Manager Project Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] cluster.max_shards_per_node should have an upper limit
4 participants
@kkewwei @dblock @shwetathareja @rajiv-kv