Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding back DEFAULT_CHUNK_SIZE to be visible to public API #14158

Merged
merged 17 commits into from
Jun 11, 2024

Conversation

astute-decipher
Copy link
Contributor

Description

This is follow up of PR #13997

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • API changes companion pull request created.
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: [Changelog](../blob/main/CONTRIBUTING.md#changelog))
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Shubh Sahu and others added 17 commits June 5, 2024 17:22
Signed-off-by: Shubh Sahu <[email protected]>
Signed-off-by: Shubh Sahu <[email protected]>
Signed-off-by: Shubh Sahu <[email protected]>
Signed-off-by: Shubh Sahu <[email protected]>
Signed-off-by: Shubh Sahu <[email protected]>
Signed-off-by: Shubh Sahu <[email protected]>
@astute-decipher astute-decipher added v2.15.0 Issues and PRs related to version 2.15.0 and removed v2.15.0 Issues and PRs related to version 2.15.0 labels Jun 11, 2024
Copy link
Contributor

❕ Gradle check result for 0bbf76a: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.71%. Comparing base (b15cb0c) to head (0bbf76a).
Report is 393 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #14158      +/-   ##
============================================
+ Coverage     71.42%   71.71%   +0.29%     
- Complexity    59978    61911    +1933     
============================================
  Files          4985     5113     +128     
  Lines        282275   290789    +8514     
  Branches      40946    41986    +1040     
============================================
+ Hits         201603   208529    +6926     
- Misses        63999    65062    +1063     
- Partials      16673    17198     +525     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gbbafna gbbafna merged commit 93d507a into opensearch-project:main Jun 11, 2024
59 of 60 checks passed
astute-decipher added a commit to astute-decipher/OpenSearch that referenced this pull request Jun 11, 2024
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants