[Backport 13821] Support Dynamic Pruning in Cardinality Aggregation #14203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t#13821) * Cardinality aggregation dynamic pruning changes Signed-off-by: bowenlan-amzn <[email protected]> * Reading Signed-off-by: bowenlan-amzn <[email protected]> * remaining disjunction scorer full understand Signed-off-by: bowenlan-amzn <[email protected]> * utilize competitive iterator api to perform pruning Signed-off-by: bowenlan-amzn <[email protected]> * handle missing input Signed-off-by: bowenlan-amzn <[email protected]> * add change log Signed-off-by: bowenlan-amzn <[email protected]> * clean up Signed-off-by: bowenlan-amzn <[email protected]> * Clean up Signed-off-by: bowenlan-amzn <[email protected]> * Test fix Signed-off-by: bowenlan-amzn <[email protected]> * Do all the scoring within Cardinality Signed-off-by: bowenlan-amzn <[email protected]> * clean unnecessary Signed-off-by: bowenlan-amzn <[email protected]> * fix Signed-off-by: bowenlan-amzn <[email protected]> * Add dynamic flag for this feature Signed-off-by: bowenlan-amzn <[email protected]> * Add random test, small bug fix Signed-off-by: bowenlan-amzn <[email protected]> * address comment Signed-off-by: bowenlan-amzn <[email protected]> * Address comments Signed-off-by: bowenlan-amzn <[email protected]> * address comments Signed-off-by: bowenlan-amzn <[email protected]> --------- Signed-off-by: bowenlan-amzn <[email protected]> Co-authored-by: Rishabh Maurya <[email protected]>
bowenlan-amzn
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
tlfeng and
VachaShah
as code owners
github-actions
bot
added
enhancement
mch2
approved these changes
Jun 12, 2024
74 tasks
This was referenced Jun 13, 2024
kkewwei
pushed a commit
to kkewwei/OpenSearch
that referenced
this pull request
Jul 24, 2024
…t#13821) (opensearch-project#14203) * Cardinality aggregation dynamic pruning changes * Reading * remaining disjunction scorer full understand * utilize competitive iterator api to perform pruning * handle missing input * add change log * clean up * Clean up * Test fix * Do all the scoring within Cardinality * clean unnecessary * fix * Add dynamic flag for this feature * Add random test, small bug fix * address comment * Address comments * address comments --------- Signed-off-by: bowenlan-amzn <[email protected]> Co-authored-by: Rishabh Maurya <[email protected]> Signed-off-by: kkewwei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport #13821 Manually
The only conflict is in change log.
Related Issues
Resolves #11959
Check List
[ ] API changes companion pull request created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.