Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for RemoteGlobalMetadataManager #14394

Merged
merged 4 commits into from
Jun 19, 2024

Conversation

shiv0408
Copy link
Member

@shiv0408 shiv0408 commented Jun 17, 2024

Description

Add tests for async read and write of attributes in RemoteGlobalMetadataManager. These flows were added in #14089, #13924 but coverage for these flows were not sufficient.

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❕ Gradle check result for c0a12f2: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.77%. Comparing base (b15cb0c) to head (b456243).
Report is 453 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #14394      +/-   ##
============================================
+ Coverage     71.42%   71.77%   +0.35%     
- Complexity    59978    62099    +2121     
============================================
  Files          4985     5118     +133     
  Lines        282275   291833    +9558     
  Branches      40946    42180    +1234     
============================================
+ Hits         201603   209456    +7853     
- Misses        63999    65066    +1067     
- Partials      16673    17311     +638     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

❌ Gradle check result for 587c566: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shiv0408
Copy link
Member Author

❌ Gradle check result for 3aefbed: FAILURE

org.opensearch.upgrades.IndexingIT.testIndexingWithSegRep - #14302

Signed-off-by: Shivansh Arora <[email protected]>
Copy link
Contributor

✅ Gradle check result for ec042aa: SUCCESS

Copy link
Contributor

❌ Gradle check result for 5924b92: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Shivansh Arora <[email protected]>
Copy link
Contributor

❌ Gradle check result for b456243: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for b456243: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@dblock dblock merged commit 8e32ed7 into opensearch-project:main Jun 19, 2024
31 of 32 checks passed
@dblock dblock added the backport 2.x Backport to 2.x branch label Jun 19, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 19, 2024
* Add tests for RemoteGlobalMetadataManager

Signed-off-by: Shivansh Arora <[email protected]>

* Add TestCapturingListener

Signed-off-by: Shivansh Arora <[email protected]>

* Move TestCapturingListener to test/framework

Signed-off-by: Shivansh Arora <[email protected]>

* Added javadoc

Signed-off-by: Shivansh Arora <[email protected]>

---------

Signed-off-by: Shivansh Arora <[email protected]>
(cherry picked from commit 8e32ed7)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dblock pushed a commit that referenced this pull request Jun 20, 2024
* Add tests for RemoteGlobalMetadataManager



* Add TestCapturingListener



* Move TestCapturingListener to test/framework



* Added javadoc



---------


(cherry picked from commit 8e32ed7)

Signed-off-by: Shivansh Arora <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
harshavamsi pushed a commit to harshavamsi/OpenSearch that referenced this pull request Jul 12, 2024
* Add tests for RemoteGlobalMetadataManager

Signed-off-by: Shivansh Arora <[email protected]>

* Add TestCapturingListener

Signed-off-by: Shivansh Arora <[email protected]>

* Move TestCapturingListener to test/framework

Signed-off-by: Shivansh Arora <[email protected]>

* Added javadoc

Signed-off-by: Shivansh Arora <[email protected]>

---------

Signed-off-by: Shivansh Arora <[email protected]>
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
…pensearch-project#14458)

* Add tests for RemoteGlobalMetadataManager

* Add TestCapturingListener

* Move TestCapturingListener to test/framework

* Added javadoc

---------

(cherry picked from commit 8e32ed7)

Signed-off-by: Shivansh Arora <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: kkewwei <[email protected]>
@shiv0408 shiv0408 self-assigned this Aug 5, 2024
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
* Add tests for RemoteGlobalMetadataManager

Signed-off-by: Shivansh Arora <[email protected]>

* Add TestCapturingListener

Signed-off-by: Shivansh Arora <[email protected]>

* Move TestCapturingListener to test/framework

Signed-off-by: Shivansh Arora <[email protected]>

* Added javadoc

Signed-off-by: Shivansh Arora <[email protected]>

---------

Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants