-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Correct RHLC searchTemplate & mtermVectors endpoints to have leading slash (#14465) #14480
[Backport 2.x] Correct RHLC searchTemplate & mtermVectors endpoints to have leading slash (#14465) #14480
Conversation
…slash (opensearch-project#14465) Signed-off-by: Thomas Farr <[email protected]> (cherry picked from commit 9675c4f)
Let’s try to get this into 2.15 as well. I labeled this with a backport. |
❌ Gradle check result for 6d28617: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 6d28617: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]>
❌ Gradle check result for b1529d7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Failing test is |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.15 2.15
# Navigate to the new working tree
pushd ../.worktrees/backport-2.15
# Create a new branch
git switch --create backport/backport-14480-to-2.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a9d806a6c4fa9b10d1a3344f446134d82dece351
# Push it to GitHub
git push --set-upstream origin backport/backport-14480-to-2.15
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.15 Then, create a pull request where the |
…slash (opensearch-project#14465) (opensearch-project#14480) Signed-off-by: Thomas Farr <[email protected]> (cherry picked from commit 9675c4f) Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]> Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]> (cherry picked from commit a9d806a)
…slash (#14465) (#14480) (#14487) Signed-off-by: Thomas Farr <[email protected]> (cherry picked from commit 9675c4f) Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]> Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]> (cherry picked from commit a9d806a)
…slash (opensearch-project#14465) (opensearch-project#14480) Signed-off-by: Thomas Farr <[email protected]> (cherry picked from commit 9675c4f) Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]> Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]> Signed-off-by: kkewwei <[email protected]>
Description
Backport 9675c4f from #14465
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.