Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Write shard level metadata blob when snapshotting searchable snapshot #14492

Merged

Conversation

andrross
Copy link
Member

Backports 568c193 from #13190 to 2.x

@bugmakerrrrrr Please review if you get a chance. There was a conflict I had to resolve in SnapshotShardsService due to some legacy code removal on the main branch.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

… indexes (opensearch-project#13190)

* fix snapshot status

Signed-off-by: panguixin <[email protected]>

* add change log

Signed-off-by: panguixin <[email protected]>

* Fix spotless violations

Signed-off-by: Andrew Ross <[email protected]>

---------

Signed-off-by: panguixin <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
Co-authored-by: Andrew Ross <[email protected]>
(cherry picked from commit 568c193)
Copy link
Contributor

@bugmakerrrrrr bugmakerrrrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

✅ Gradle check result for 868e1e4: SUCCESS

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 48.14815% with 14 lines in your changes missing coverage. Please review.

Project coverage is 71.50%. Comparing base (0dd892c) to head (868e1e4).
Report is 406 commits behind head on 2.x.

Files Patch % Lines
...rg/opensearch/snapshots/SnapshotShardsService.java 50.00% 7 Missing and 5 partials ⚠️
...ch/repositories/blobstore/BlobStoreRepository.java 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #14492      +/-   ##
============================================
+ Coverage     71.28%   71.50%   +0.21%     
- Complexity    60145    62266    +2121     
============================================
  Files          4957     5095     +138     
  Lines        282799   292735    +9936     
  Branches      41409    42678    +1269     
============================================
+ Hits         201591   209311    +7720     
- Misses        64189    65850    +1661     
- Partials      17019    17574     +555     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrross andrross merged commit e419c6e into opensearch-project:2.x Jun 21, 2024
49 of 51 checks passed
@andrross andrross deleted the backport/backport-13190-to-2.x branch June 21, 2024 17:57
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
… indexes (opensearch-project#13190) (opensearch-project#14492)

* fix snapshot status

Signed-off-by: panguixin <[email protected]>

* add change log

Signed-off-by: panguixin <[email protected]>

* Fix spotless violations

Signed-off-by: Andrew Ross <[email protected]>

---------

Signed-off-by: panguixin <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
Co-authored-by: Andrew Ross <[email protected]>
(cherry picked from commit 568c193)

Co-authored-by: panguixin <[email protected]>
Signed-off-by: kkewwei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants