Add buffer for allocation constraints and a switch to disable index b… #14515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alance constraint Signed-off-by: Gaurav Bafna <[email protected]>
gbbafna
commented
Jun 24, 2024
...c/main/java/org/opensearch/cluster/routing/allocation/allocator/BalancedShardsAllocator.java
Outdated
Show resolved
Hide resolved
|
❌ Gradle check result for 950b9ab: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Gaurav Bafna <[email protected]>
...c/main/java/org/opensearch/cluster/routing/allocation/allocator/BalancedShardsAllocator.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/opensearch/cluster/routing/allocation/allocator/BalancedShardsAllocator.java
Outdated
Show resolved
Hide resolved
|
❕ Gradle check result for cf053d2: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14515 +/- ##
============================================
+ Coverage 71.42% 71.74% +0.32%
- Complexity 59978 62123 +2145
============================================
Files 4985 5119 +134
Lines 282275 292022 +9747
Branches 40946 42212 +1266
============================================
+ Hits 201603 209522 +7919
- Misses 63999 65266 +1267
- Partials 16673 17234 +561 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Gaurav Bafna <[email protected]>
gbbafna
force-pushed
the
switch-for-constraint
branch
from
2bcc876
to
a82e4f5
Compare
|
❌ Gradle check result for 2bcc876: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
This was referenced Jun 24, 2024
gbbafna
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159 and
sachinpkale
as code owners
gbbafna
requested review from
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
sachinpkale
reviewed
Jun 25, 2024
server/src/main/java/org/opensearch/cluster/routing/allocation/ConstraintTypes.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/cluster/routing/allocation/Constraint.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/cluster/routing/allocation/RebalanceConstraints.java
Show resolved
Hide resolved
...c/main/java/org/opensearch/cluster/routing/allocation/allocator/BalancedShardsAllocator.java
Show resolved
Hide resolved
Signed-off-by: Gaurav Bafna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…alance constraint
Description
Add buffer for allocation constraints and a switch to disable index balance constraints
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.