Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SortResponseProcessor to Search Pipelines #14785

Merged
merged 9 commits into from
Jul 22, 2024
Merged

Add SortResponseProcessor to Search Pipelines #14785

merged 9 commits into from
Jul 22, 2024

Commits on Jul 22, 2024

  1. Add SortResponseProcessor for search pipelines 

    Signed-off-by: Daniel Widdis <[email protected]>
    @dbwiddis
    dbwiddis committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    1decd3f View commit details
    Browse the repository at this point in the history

  2. Add stupid and unnecessary javadocs to satisfy overly strict CI 

    Signed-off-by: Daniel Widdis <[email protected]>
    @dbwiddis
    dbwiddis committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    874a6f3 View commit details
    Browse the repository at this point in the history

  3. Split casting and sorting methods for readability 

    Signed-off-by: Daniel Widdis <[email protected]>
    @dbwiddis
    dbwiddis committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    94b1130 View commit details
    Browse the repository at this point in the history

  4. Register the sort processor factory 

    Signed-off-by: Daniel Widdis <[email protected]>
    @dbwiddis
    dbwiddis committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    a9c79a3 View commit details
    Browse the repository at this point in the history

  5. Address code review comments 

    Signed-off-by: Daniel Widdis <[email protected]>
    @dbwiddis
    dbwiddis committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    a5e2ffe View commit details
    Browse the repository at this point in the history

  6. Cast individual list elements to avoid creating two lists 

    Signed-off-by: Daniel Widdis <[email protected]>
    @dbwiddis
    dbwiddis committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    e00e8d5 View commit details
    Browse the repository at this point in the history

  7. Add yamlRestTests 

    Signed-off-by: Daniel Widdis <[email protected]>
    @dbwiddis
    dbwiddis committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    953a705 View commit details
    Browse the repository at this point in the history

  8. Clarify why there's unusual sorting 

    Signed-off-by: Daniel Widdis <[email protected]>
    @dbwiddis
    dbwiddis committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    37737e7 View commit details
    Browse the repository at this point in the history

  9. Use instanceof instead of isAssignableFrom 

    Signed-off-by: Daniel Widdis <[email protected]>
    @dbwiddis
    dbwiddis committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    5bc8c4d View commit details
    Browse the repository at this point in the history