Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.16] Implement write and read flow for shard diff file. #14922

Merged
merged 1 commit into from
Jul 24, 2024
Merged

[Backport 2.16] Implement write and read flow for shard diff file. #14922

merged 1 commit into from
Jul 24, 2024

Conversation

shailendra0811
Copy link
Contributor

@shailendra0811 shailendra0811 commented Jul 23, 2024 •
edited
Loading

Backport f85a58f from #14684

@shailendra0811 shailendra0811 changed the title [Backport 2.16] Implement write and read flow for shard diff file [Backport 2.16] Implement write and read flow to upload/download shard diff file Jul 23, 2024
@shailendra0811 shailendra0811 changed the title [Backport 2.16] Implement write and read flow to upload/download shard diff file [Backport 2.16] Implement write and read flow for shard diff file. Jul 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for b395103: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@Arpit-Bandejiya
Copy link
Contributor

Flaky test: #1703

@prudhvigodithi prudhvigodithi mentioned this pull request Jul 23, 2024
Closed
74 tasks
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for e046377: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for e046377: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shiv0408 shiv0408 mentioned this pull request Jul 23, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for e046377:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 69db981: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for da53cbb: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for da53cbb:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for da53cbb:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for e14c877: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shailendra0811
[Remote Routing Table] Implement write and read flow for shard diff f…
cc48576 
…ile. (opensearch-project#14684)

* Implement write and read flow to upload/download shard diff file.

Signed-off-by: Shailendra Singh <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for cc48576: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 74.07407% with 56 lines in your changes missing coverage. Please review.

Project coverage is 71.59%. Comparing base (1c28e4e) to head (cc48576).
Report is 10 commits behind head on 2.16.

Files Patch % Lines
...arch/gateway/remote/RemoteClusterStateService.java 57.77% 14 Missing and 5 partials ⚠️
...h/cluster/routing/RoutingTableIncrementalDiff.java 82.97% 8 Missing ⚠️
...teway/remote/RemoteClusterStateCleanupManager.java 52.94% 6 Missing and 2 partials ⚠️
...ay/remote/routingtable/RemoteRoutingTableDiff.java 76.66% 4 Missing and 3 partials ⚠️
...earch/gateway/remote/ClusterStateDiffManifest.java 76.19% 2 Missing and 3 partials ⚠️
.../routing/remote/NoopRemoteRoutingTableService.java 57.14% 3 Missing ⚠️
...ster/routing/remote/RemoteRoutingTableService.java 76.92% 2 Missing and 1 partial ⚠️
...nsearch/gateway/remote/RemotePersistenceStats.java 60.00% 2 Missing ⚠️
...ting/remote/InternalRemoteRoutingTableService.java 95.45% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               2.16   #14922      +/-   ##
============================================
+ Coverage     71.55%   71.59%   +0.04%     
- Complexity    62652    62709      +57     
============================================
  Files          5117     5120       +3     
  Lines        293928   294258     +330     
  Branches      42833    42880      +47     
============================================
+ Hits         210319   210677     +358     
+ Misses        65975    65937      -38     
- Partials      17634    17644      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bukhtawar Bukhtawar merged commit 06698dd into opensearch-project:2.16 Jul 24, 2024
32 checks passed
This was referenced Sep 6, 2024
Open
Open
Open
Open
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bukhtawar Bukhtawar Bukhtawar approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shailendra0811 @Arpit-Bandejiya @Bukhtawar