Fix read/write in stream method for Diff Manifest when shard diff file is null #14938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shailendra0811
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
shailendra0811
changed the title
|
❌ Gradle check result for 7f00ba4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
shailendra0811
force-pushed
the
singlhs-shard-diff-fix
branch
from
7f00ba4
to
5f26045
Compare
himshikha
approved these changes
Jul 24, 2024
Signed-off-by: Shailendra Singh <[email protected]>
shailendra0811
force-pushed
the
singlhs-shard-diff-fix
branch
from
5f26045
to
27e90df
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14938 +/- ##
============================================
- Coverage 71.89% 71.75% -0.14%
+ Complexity 62701 62670 -31
============================================
Files 5159 5159
Lines 294157 294156 -1
Branches 42547 42547
============================================
- Hits 211492 211084 -408
- Misses 65200 65748 +548
+ Partials 17465 17324 -141 ☔ View full report in Codecov by Sentry. |
shailendra0811
changed the title
Bukhtawar
approved these changes
Jul 24, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 24, 2024
…ll. (#14938) Signed-off-by: Shailendra Singh <[email protected]> (cherry picked from commit 5744eae) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 24, 2024
…ll. (#14938) Signed-off-by: Shailendra Singh <[email protected]> (cherry picked from commit 5744eae) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Jul 24, 2024
[Backport 2.x] Fix read/write in stream method for Diff Manifest when shard diff file is null
#14947
Merged
harshavamsi
pushed a commit
to harshavamsi/OpenSearch
that referenced
this pull request
Aug 20, 2024
…ll. (opensearch-project#14938) Signed-off-by: Shailendra Singh <[email protected]>
wdongyu
pushed a commit
to wdongyu/OpenSearch
that referenced
this pull request
Aug 22, 2024
…ll. (opensearch-project#14938) Signed-off-by: Shailendra Singh <[email protected]>
This was referenced Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
IndicesRoutingDiffPath would be null in diff manifest when there are no updates in routing table. Currently we are not handling null values and it will throw an EOFException if it encounters a null when trying to read/write indicesRoutingDiffPath in/from diff manifest.
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.