Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.16] Template Creation using Context #14957

Merged

Conversation

mgodwan
Copy link
Member

@mgodwan mgodwan commented Jul 24, 2024

Backport of #14811

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Template creation using context

Signed-off-by: Mohit Godwani <[email protected]>
Copy link
Contributor

❕ Gradle check result for 7f924b8: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testWriteLargeBlob

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 73.91304% with 42 lines in your changes missing coverage. Please review.

Project coverage is 71.59%. Comparing base (a3a4aa9) to head (7f924b8).
Report is 1 commits behind head on 2.16.

Files Patch % Lines
.../java/org/opensearch/cluster/metadata/Context.java 67.34% 14 Missing and 2 partials ⚠️
...r/applicationtemplates/SystemTemplateMetadata.java 20.00% 6 Missing and 2 partials ⚠️
...plicationtemplates/TemplateRepositoryMetadata.java 0.00% 6 Missing ⚠️
...arch/cluster/metadata/ComposableIndexTemplate.java 75.00% 1 Missing and 3 partials ⚠️
...cluster/metadata/MetadataIndexTemplateService.java 94.11% 2 Missing and 1 partial ⚠️
...ate/post/TransportSimulateIndexTemplateAction.java 0.00% 2 Missing ⚠️
...template/post/TransportSimulateTemplateAction.java 0.00% 2 Missing ⚠️
...ch/cluster/coordination/OpenSearchNodeCommand.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               2.16   #14957      +/-   ##
============================================
+ Coverage     71.55%   71.59%   +0.04%     
- Complexity    62686    62750      +64     
============================================
  Files          5120     5121       +1     
  Lines        294256   294402     +146     
  Branches      42880    42903      +23     
============================================
+ Hits         210543   210775     +232     
+ Misses        66092    65955     -137     
- Partials      17621    17672      +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbwiddis dbwiddis merged commit 61cd3fd into opensearch-project:2.16 Jul 24, 2024
51 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants