Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lower limit for primary and replica batch allocators timeout #14979

Merged
merged 7 commits into from
Jul 30, 2024

Conversation

imRishN
Copy link
Member

@imRishN imRishN commented Jul 25, 2024

Description

With this #14848 we added cluster settings for allocator's timeout of which default value is MINUS_ONE. This PR adds a min limit to this setting such that very small values are not added to these settings.

Related Issues

Resolves #14941

Check List

  • Functionality includes testing.
  • [] API changes companion pull request created, if applicable.
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@shwetathareja
Copy link
Member

Also add the changelog for it.

Signed-off-by: Rishab Nahata <[email protected]>
Copy link
Contributor

❌ Gradle check result for a0e1606: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@imRishN imRishN added the backport 2.x Backport to 2.x branch label Jul 27, 2024
Copy link
Contributor

❌ Gradle check result for ed09df1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for e34e76d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Rishab Nahata <[email protected]>
Copy link
Contributor

❌ Gradle check result for 26b1d87: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Rishab Nahata <[email protected]>
Copy link
Contributor

✅ Gradle check result for eb7c936: SUCCESS

Copy link

codecov bot commented Jul 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.90%. Comparing base (1fe58b5) to head (eb7c936).
Report is 6 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #14979      +/-   ##
============================================
+ Coverage     71.78%   71.90%   +0.11%     
- Complexity    62694    62743      +49     
============================================
  Files          5160     5161       +1     
  Lines        294211   294372     +161     
  Branches      42553    42579      +26     
============================================
+ Hits         211212   211671     +459     
+ Misses        65599    65232     -367     
- Partials      17400    17469      +69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bukhtawar Bukhtawar merged commit 09276b3 into opensearch-project:main Jul 30, 2024
34 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 30, 2024
)

* Add lower limit for primary and replica batch allocators

Signed-off-by: Rishab Nahata <[email protected]>
(cherry picked from commit 09276b3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dblock pushed a commit that referenced this pull request Aug 6, 2024
) (#15026)

* Add lower limit for primary and replica batch allocators


(cherry picked from commit 09276b3)

Signed-off-by: Rishab Nahata <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
harshavamsi pushed a commit to harshavamsi/OpenSearch that referenced this pull request Aug 20, 2024
…nsearch-project#14979)

* Add lower limit for primary and replica batch allocators

Signed-off-by: Rishab Nahata <[email protected]>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
…nsearch-project#14979)

* Add lower limit for primary and replica batch allocators

Signed-off-by: Rishab Nahata <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working Cluster Manager Other
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[BUG] Validate lower limit for Allocator Timeout
4 participants