Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version check after backport #14985

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

mgodwan
Copy link
Member

@mgodwan mgodwan commented Jul 26, 2024

Fix version check after backport

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@shwetathareja shwetathareja added skip-changelog backport 2.x Backport to 2.x branch and removed backport 2.x Backport to 2.x branch labels Jul 26, 2024
Copy link
Contributor

❌ Gradle check result for 5754b0b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 5754b0b: SUCCESS

Copy link
Contributor

✅ Gradle check result for 563f69c: SUCCESS

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.79%. Comparing base (1fe58b5) to head (563f69c).
Report is 5 commits behind head on main.

Files Patch % Lines
...arch/cluster/metadata/ComposableIndexTemplate.java 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               main   #14985    +/-   ##
==========================================
  Coverage     71.78%   71.79%            
- Complexity    62694    62731    +37     
==========================================
  Files          5160     5161     +1     
  Lines        294211   294357   +146     
  Branches      42553    42576    +23     
==========================================
+ Hits         211212   211329   +117     
- Misses        65599    65654    +55     
+ Partials      17400    17374    -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgodwan
Copy link
Member Author

mgodwan commented Jul 26, 2024

Codecov is failing due to partial hits on if condition i.e. no false evaluation
We cannot provide a version less than 2.16 since cluster won't come up itself due to wire compatibility failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants