-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setting to ignore throttling nodes for allocation of unassigned … #14991
Conversation
...c/main/java/org/opensearch/cluster/routing/allocation/allocator/BalancedShardsAllocator.java
Outdated
Show resolved
Hide resolved
❌ Gradle check result for 07c57be: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
...r/src/main/java/org/opensearch/cluster/routing/allocation/allocator/LocalShardsBalancer.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
...r/src/main/java/org/opensearch/cluster/routing/allocation/allocator/LocalShardsBalancer.java
Show resolved
Hide resolved
...r/src/test/java/org/opensearch/cluster/routing/allocation/DecideAllocateUnassignedTests.java
Outdated
Show resolved
Hide resolved
...r/src/test/java/org/opensearch/cluster/routing/allocation/DecideAllocateUnassignedTests.java
Outdated
Show resolved
Hide resolved
...r/src/test/java/org/opensearch/cluster/routing/allocation/DecideAllocateUnassignedTests.java
Show resolved
Hide resolved
...r/src/test/java/org/opensearch/cluster/routing/allocation/DecideAllocateUnassignedTests.java
Outdated
Show resolved
Hide resolved
...r/src/test/java/org/opensearch/cluster/routing/allocation/DecideAllocateUnassignedTests.java
Outdated
Show resolved
Hide resolved
...r/src/test/java/org/opensearch/cluster/routing/allocation/DecideAllocateUnassignedTests.java
Outdated
Show resolved
Hide resolved
...r/src/test/java/org/opensearch/cluster/routing/allocation/DecideAllocateUnassignedTests.java
Show resolved
Hide resolved
…rimaries in restore in order to speed up remote restore Signed-off-by: Gaurav Bafna <[email protected]>
Signed-off-by: Gaurav Bafna <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
❌ Gradle check result for 029c2ae: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14991 +/- ##
============================================
+ Coverage 71.77% 71.79% +0.01%
- Complexity 62689 62799 +110
============================================
Files 5163 5163
Lines 294412 294422 +10
Branches 42582 42586 +4
============================================
+ Hits 211325 211389 +64
+ Misses 65689 65648 -41
+ Partials 17398 17385 -13 ☔ View full report in Codecov by Sentry. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-14991-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5c19809ec05d0a2cf03a5105c5333303bc21cb0d
# Push it to GitHub
git push --set-upstream origin backport/backport-14991-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…emote primaries (opensearch-project#14991) Signed-off-by: Gaurav Bafna <[email protected]>
…emote primaries (#14991) (#15030) Signed-off-by: Gaurav Bafna <[email protected]>
…emote primaries (opensearch-project#14991) Signed-off-by: Gaurav Bafna <[email protected]>
…emote primaries (opensearch-project#14991) Signed-off-by: Gaurav Bafna <[email protected]>
…primaries in restore in order to speed up remote restore
Description
For remote store backed domains, if a node in the cluster is replaced by a new node and we trigger restore for all the red indices, all the recoveries are happening only on the new node .
This allocation to only one node is due to balancer weights as well multiple Allocation Constraints, which provides weight to each node. We will assign shards only to the node with minimum weight . The new node will always have minimum weight for all the unassigned shards. The new node will keep throttling the recoveries, until the existing recoveries are done. This results in slowing down the overall recovery time.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.