Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MacOS Mx (arm64) and Linux (arm64, ppc64le, s390x) checks #15036

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

reta
Copy link
Collaborator

@reta reta commented Jul 31, 2024

Description

While working on aarch64 distributions for MacOS, @peterzhuamazon reported an issue that Gradle checks fails to run:

* What went wrong:                                                                                                                                                                                                                                                                                                                                    
Could not determine the dependencies of task ':qa:full-cluster-restart:v1.3.19#upgradedClusterTest'.                                                                                                                                                                                                                                                  
> Could not resolve all dependencies for configuration ':qa:full-cluster-restart:opensearch_distro_extracted_testclusters-qa-full-cluster-restart-v1.3.19-0-1.3.19-'.
   > Could not resolve project :distribution:bwc:maintenance.                         
     Required by:                                                                                                                              
         project :qa:full-cluster-restart                                             
      > A dependency was declared on configuration 'expanded-darwin-arm64-tar' which is not declared in the descriptor for project :distribution:bwc:maintenance. 

Related Issues

Part of opensearch-project/opensearch-build#4670

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta reta added bug Something isn't working skip-changelog Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. labels Jul 31, 2024
@reta reta added backport 1.x backport 2.x Backport to 2.x branch backport 1.3 Backport to 1.3 branch backport 2.16 labels Jul 31, 2024
Copy link
Contributor

✅ Gradle check result for f9e8afc: SUCCESS

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.89%. Comparing base (eb306d2) to head (f9e8afc).
Report is 2 commits behind head on main.

Files Patch % Lines
...e/internal/InternalDistributionBwcSetupPlugin.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15036      +/-   ##
============================================
+ Coverage     71.77%   71.89%   +0.11%     
- Complexity    62689    62772      +83     
============================================
  Files          5163     5165       +2     
  Lines        294412   294438      +26     
  Branches      42582    42587       +5     
============================================
+ Hits         211325   211685     +360     
+ Misses        65689    65307     -382     
- Partials      17398    17446      +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dblock dblock merged commit d158ec6 into opensearch-project:main Jul 31, 2024
77 of 78 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 31, 2024
Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit d158ec6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 31, 2024
Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit d158ec6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 31, 2024
Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit d158ec6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 31, 2024
Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit d158ec6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Jul 31, 2024
#15042)

(cherry picked from commit d158ec6)

Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Jul 31, 2024
#15040)

(cherry picked from commit d158ec6)

Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Jul 31, 2024
#15041)

(cherry picked from commit d158ec6)

Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Jul 31, 2024
#15043)

(cherry picked from commit d158ec6)

Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
harshavamsi pushed a commit to harshavamsi/OpenSearch that referenced this pull request Aug 20, 2024
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.x backport 1.3 Backport to 1.3 branch backport 2.x Backport to 2.x branch backport 2.16 bug Something isn't working Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants