Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic for getting maintainer ids for benchmark workflow #15236

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

rishabh6788
Copy link
Contributor

Description

This PR fixes the logic to fetch maintainer id list from CODEOWNERS file in benchmark-pull-request workflow.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • [ ] Functionality includes testing.
  • [ ] API changes companion pull request created, if applicable.
  • [ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@rishabh6788
Copy link
Contributor Author

@jed326 your approval should be sufficient since you are one of the maintainers, right?

@jed326
Copy link
Collaborator

jed326 commented Aug 14, 2024

@jed326 your approval should be sufficient since you are one of the maintainers, right?

I think PRs need to be approved again if any changes are pushed after approvals

@peternied peternied merged commit f1f721f into opensearch-project:main Aug 14, 2024
32 checks passed
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
@peternied peternied added the backport 2.x Backport to 2.x branch label Aug 28, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15236-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f1f721f55ef727a69f4f0f180096461de5a94406
# Push it to GitHub
git push --set-upstream origin backport/backport-15236-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-15236-to-2.x.

@peternied
Copy link
Member

@rishabh6788 Looks like you can only assign up to 10 people on the issues being created, see #15458. Consider creating an issue if you'd like to fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants